This repository has been archived by the owner on Jun 10, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Report granted permissions in the user-joined message #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tombuMS
approved these changes
Jul 8, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
jabenk
added a commit
that referenced
this pull request
Jul 15, 2020
* Physics (#210) * Jabenk/physics dev (#190) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * Avoid using events and handlers for physics bridge (#193) * Jabenk/physics dev (#196) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * Jabenk/physics dev (#201) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * current WIP for sleeping bodies * Add velocities only if legacy physics is working * Jitter buffer refactoring (#199) * Jabenk/physics dev (#204) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * current WIP for sleeping bodies * Add velocities only if legacy physics is working * server upload transform currend dev state * dev update: * Current dev state * physics bridge: upload RBs transforms to server * physics bridge: working client transform upload stream * physics bridge: transform server upload working * Minor polishing and testing * Add a test scene with 3 clients * Adding minor comments * Code review * Jabenk/smallchanges (#206) * Adding subscription to the rigid body velocities * Add missing code comment * Process all snapshots in jitter buffer (#208) * Jitter buffer variance and other fixes (#211) * fixes (#212) Co-authored-by: Nikola Nikolic <n.nikolic@outlook.com> * Report granted permissions in the user-joined message (#214) * Add fallback permissions for apps without a manifest (#217) * User ID Generation Update (#216) * Implement user ID generation in to the unity runtime * Implement user id changes in to the two test beds * Remove debug log statement * Remove string builder where not needed Co-authored-by: Nikola Nikolic <n.nikolic@outlook.com> Co-authored-by: Steven Vergenz <steven.vergenz@microsoft.com> Co-authored-by: Tom Burdak <40439150+tombuMS@users.noreply.github.com>
jabenk
added a commit
that referenced
this pull request
Jul 20, 2020
* Jabenk/physics dev (#190) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * Avoid using events and handlers for physics bridge (#193) * Jabenk/physics dev (#196) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * Jabenk/physics dev (#201) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * current WIP for sleeping bodies * Add velocities only if legacy physics is working * Jitter buffer refactoring (#199) * Jabenk/physics dev (#204) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * current WIP for sleeping bodies * Add velocities only if legacy physics is working * server upload transform currend dev state * dev update: * Current dev state * physics bridge: upload RBs transforms to server * physics bridge: working client transform upload stream * physics bridge: transform server upload working * Minor polishing and testing * Add a test scene with 3 clients * Adding minor comments * Code review * Jabenk/smallchanges (#206) * Adding subscription to the rigid body velocities * Add missing code comment * Process all snapshots in jitter buffer (#208) * Jitter buffer variance and other fixes (#211) * fixes (#212) * Enable 30Hz physics updates (#213) * Fix jitter buffer update flag (#215) * Jabenk/mouse pick (#218) * If there is no rigid body update do not send physics bridge update * Moving untility function to a more appropriate class * Use really 30Hz * Move the velocity estimaiton into the JB instead as a post processing * Add more commented debug statements * Code review * Keep last packet at least for 100ms for possible interpolation (#219) * Jabenk/physics merge (#221) * Physics (#210) * Jabenk/physics dev (#190) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * Avoid using events and handlers for physics bridge (#193) * Jabenk/physics dev (#196) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * Jabenk/physics dev (#201) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * current WIP for sleeping bodies * Add velocities only if legacy physics is working * Jitter buffer refactoring (#199) * Jabenk/physics dev (#204) * If there is no rigid body update do not send physics bridge update * Intermediate state of the sleeping bdoies * Current state of the sleeping bodies * Current state of sleeping bodies * Minor updates before red merge * Current debug state of the sleeping body + jitter buffer debuging * Sleeping bodies current dev state * Converging state of the sleeping bodies feature * Minor polishing of sleeping bodies * easing tolerances for sleeping * PR update * add velocity capping for the estimated velocities on the JB reciever end + if body is sleeping then those velocities should be zero * set low value for the depenetration velocity * Current dev debug state * current debug state of high velocity * current debug state of high velocity * Adding final version of the safty net for velocity * Setting more conservative parameters * Temporarly remove the velocity channel since this adds quite some additional bandwith, later we should make this optional * more fine tuning for the sleeping condition and more meaningfull activable debug informaiton * current WIP for sleeping bodies * Add velocities only if legacy physics is working * server upload transform currend dev state * dev update: * Current dev state * physics bridge: upload RBs transforms to server * physics bridge: working client transform upload stream * physics bridge: transform server upload working * Minor polishing and testing * Add a test scene with 3 clients * Adding minor comments * Code review * Jabenk/smallchanges (#206) * Adding subscription to the rigid body velocities * Add missing code comment * Process all snapshots in jitter buffer (#208) * Jitter buffer variance and other fixes (#211) * fixes (#212) Co-authored-by: Nikola Nikolic <n.nikolic@outlook.com> * Report granted permissions in the user-joined message (#214) * Add fallback permissions for apps without a manifest (#217) * User ID Generation Update (#216) * Implement user ID generation in to the unity runtime * Implement user id changes in to the two test beds * Remove debug log statement * Remove string builder where not needed Co-authored-by: Nikola Nikolic <n.nikolic@outlook.com> Co-authored-by: Steven Vergenz <steven.vergenz@microsoft.com> Co-authored-by: Tom Burdak <40439150+tombuMS@users.noreply.github.com> * Fix merge error * PR minor whitespace correction Co-authored-by: Nikola Nikolic <n.nikolic@outlook.com> Co-authored-by: Steven Vergenz <steven.vergenz@microsoft.com> Co-authored-by: Tom Burdak <40439150+tombuMS@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #203