Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement automatically choosing a suitable model wrapper #24

Merged
merged 5 commits into from
Jun 10, 2022
Merged

Implement automatically choosing a suitable model wrapper #24

merged 5 commits into from
Jun 10, 2022

Conversation

anamika-yadav99
Copy link
Contributor

@anamika-yadav99 anamika-yadav99 commented May 29, 2022 •
edited by kmaziarz
Loading

This PR adds a load_model_from_directory function, which can load any model (both VAE-style and generator-style) by automatically choosing the right wrapper class.

@ghost
Copy link

ghost commented May 29, 2022 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@kmaziarz kmaziarz self-requested a review May 29, 2022 22:21
kmaziarz
kmaziarz requested changes May 30, 2022
View reviewed changes
Copy link
Collaborator

@kmaziarz kmaziarz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks; this is roughly what I was thinking of, but we should make a few more cleanups. Please also make sure to drop the debug print, commented out code, and trailing whitespaces.

molecule_generation/cli/sample.py Outdated Show resolved Hide resolved
molecule_generation/wrapper.py Outdated Show resolved Hide resolved
molecule_generation/wrapper.py Outdated Show resolved Hide resolved
molecule_generation/wrapper.py Outdated Show resolved Hide resolved
@kmaziarz kmaziarz linked an issue May 30, 2022 that may be closed by this pull request
Make CLI support all relevant model types #13
Closed
@kmaziarz
Copy link
Collaborator

kmaziarz commented Jun 6, 2022

Thanks @anamika-yadav99, I'll take it from here!

@kmaziarz kmaziarz changed the title WIP: Added GeneratorWrapper and VaeWrapper to cli/sample.py and get_model_class to model_utils.py Implement automatically choosing a suitable model wrapper Jun 9, 2022
kmaziarz added a commit to anamika-yadav99/molecule-generation that referenced this pull request Jun 10, 2022
@kmaziarz
doc(CHANGELOG): Add an entry for microsoft#24
b9adfed
@kmaziarz kmaziarz merged commit 3d8ace9 into microsoft:main Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmaziarz kmaziarz kmaziarz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make CLI support all relevant model types
2 participants
@anamika-yadav99 @kmaziarz