Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Website does not pick up new tokenizers #2807

Closed
hediet opened this issue Dec 8, 2021 · 6 comments
Closed

Website does not pick up new tokenizers #2807

hediet opened this issue Dec 8, 2021 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@hediet
Copy link
Member

hediet commented Dec 8, 2021

when building the website locally it always used the old version of tokenizers, I even tried resetting the repo, running install, release, build-website, simpleserver and it would still pick up the old version. Is there an option to build from local files?

(from #2806, @jonatanklosko)

@hediet hediet added the bug Issue identified by VS Code Team member as probable bug label Dec 8, 2021
@jonatanklosko
Copy link
Contributor

Ah, and also I needed to manually create test/manual/generated, most likely because the directory is assumed to exist here:

fs.writeFileSync(
path.join(REPO_ROOT, 'test/manual/generated/all-samples.js'),
prefix + JSON.stringify(samples, null, '\t') + suffix
);

Thanks!

@alexdima
Copy link
Member

alexdima commented Dec 8, 2021

@hediet the website reflects the latest (stable) released editor, it does not reflect the sources in the main branch of this repository, nor the nightly npm releases. The website is the equivalent of vscode.dev, not of insiders.vscode.dev.

But @jonatanklosko you are correct, there is a mkdir missing somewhere in there.

@alexdima alexdima added this to the December 2021 milestone Dec 8, 2021
@jonatanklosko
Copy link
Contributor

@alexdima makes sense, thanks! For the record, it would be helpful to have an option of running the latest version locally, especially for verifying highlighting.

@alexdima
Copy link
Member

alexdima commented Dec 8, 2021

@jonatanklosko I agree, to verify highlighting currently the following is possible:

I will take a look to fix http://127.0.0.1:8080/monaco-editor/website/ which looks like it got broken during the repo merge.

@alexdima
Copy link
Member

alexdima commented Dec 8, 2021

Now the following should work too:

@alexdima alexdima closed this as completed Dec 8, 2021
@jonatanklosko
Copy link
Contributor

Fantastic, both of these work for me now, thanks :D

@alexdima alexdima modified the milestones: December 2021, November 2021 Dec 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants