Resolve URIs with special characters correctly #3392
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, model URIs were synced with typescript without encoding (
uri.toString(true)
), breaking resolution of URIs that had special characters in them, e.g.file:///node_modules/@some/module
orfile:///C:/test.js
. This fix makes sure that typescript sees the correct, encoded file URIs. I've also verified that features likePeek Definition
is still working with this fix.Fixes #3281
Fixes #3236
History:
675844a tried to introduce a fix for this problem, but only provided half the solution. This new patch still solves #2295 which was the original target for that commit, while also fixing the encoding problems entirely.