Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change moduleResolution to node16 and adopt TS 5.0 #3860

Merged
merged 3 commits into from
Mar 27, 2023
Merged

Change moduleResolution to node16 and adopt TS 5.0 #3860

merged 3 commits into from
Mar 27, 2023

Conversation

tamayika
Copy link
Contributor

#3855 was due to require() breaking change in TS 4.9.
But we don't need to transpile dynamic import to require(), so I change moduleResolution to node16 and reverted merge commit.

@tamayika tamayika mentioned this pull request Mar 23, 2023
Closed
2 tasks
@hediet hediet modified the milestones: March 2023, April 2023 Mar 23, 2023
@hediet hediet enabled auto-merge March 27, 2023 12:01
@hediet hediet merged commit e531b5c into microsoft:main Mar 27, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joaomoreno joaomoreno joaomoreno approved these changes

@hediet hediet hediet approved these changes

@alexr00 alexr00 alexr00 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@tamayika @joaomoreno @hediet @alexr00