-
Notifications
You must be signed in to change notification settings - Fork 28
Add config to disable default formatter #10
Conversation
@aeschli is this what you imagined? |
Having it as part of Maybe a Capabilities property on the |
Thank you for taking a look at my PR. I updated it to follow your suggestions. |
Thanks, improvements are good. Also, now |
Oh, I misunderstood your comment and didn't read Capabilities as I had assumed that |
What are the |
Done. Let me know if this is what you imagined. Btw, I noticed that the indentation is inconsistent (space vs tabs). What's the preferred indentation? |
looks good! |
I can remove |
Thanks, I'll take it from here! |
Thank you. Monaco is really awesome and especially the JSON support has been phenomenal for the editor we are building (https://vega.github.io/editor/). |
src/monaco.d.ts
Outdated
/** | ||
* Disable the default JSON formatter. | ||
* Defines wheter the built-in documentFormattingEdit provider is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo. Should be "whether".
src/monaco.d.ts
Outdated
readonly documentFormattingEdits?: boolean; | ||
|
||
/** | ||
* Defines wheter the built-in documentRangeFormattingEdit provider is enabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same typo as above (also note the same typo below)
@alexandrudima Here's what we ended up with the APIs to enable/disable certain providers in JSON. |
Any updates on this @aeschli @alexandrudima? |
fixes microsoft/monaco-editor#889