Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring NVLS interfaces #293

Merged
merged 2 commits into from
Apr 24, 2024
Merged

Refactoring NVLS interfaces #293

merged 2 commits into from
Apr 24, 2024

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Apr 23, 2024 •
edited
Loading

Move NVLS details from the core to a separate interface

Binyang2014
Binyang2014 approved these changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate NVLS related code to another class looks good to me. Agree with NVLS is not a kind of connection.

@chhwang chhwang merged commit 6c1fa53 into main Apr 24, 2024
15 checks passed
@chhwang chhwang deleted the chhwang/nvls branch April 24, 2024 17:05
@chhwang chhwang mentioned this pull request May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Binyang2014 Binyang2014 Binyang2014 approved these changes

@roshandathathri roshandathathri Awaiting requested review from roshandathathri

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chhwang @Binyang2014