Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite mscclpp-test with cpp style API #77

Merged
merged 11 commits into from
May 19, 2023
Merged

Rewrite mscclpp-test with cpp style API #77

merged 11 commits into from
May 19, 2023

Conversation

Binyang2014
Copy link
Contributor

@Binyang2014 Binyang2014 commented May 17, 2023 •
edited
Loading

  • Rewrite mscclpp-test with cpp style API
  • Add SM copy
  • add new sendRecv test

@Binyang2014 Binyang2014 changed the title Rewrite mscclpp-test will cpp style API Rewrite mscclpp-test with cpp style API May 18, 2023
saeedmaleki
saeedmaleki reviewed May 18, 2023
View reviewed changes
include/mscclpp/channel.hpp Show resolved Hide resolved
test/mscclpp-test/common.hpp Outdated Show resolved Hide resolved
test/mscclpp-test/common.hpp Outdated Show resolved Hide resolved
test/mscclpp-test/common.hpp Outdated Show resolved Hide resolved
test/mscclpp-test/sendrecv_test.cu Outdated Show resolved Hide resolved
saeedmaleki
saeedmaleki approved these changes May 18, 2023
View reviewed changes
Copy link
Contributor

@saeedmaleki saeedmaleki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor changes.

@Binyang2014 Binyang2014 enabled auto-merge (squash) May 19, 2023 05:14
@Binyang2014 Binyang2014 merged commit a3cf48c into main May 19, 2023
@Binyang2014 Binyang2014 deleted the binyli/mscclpp-test branch May 19, 2023 06:14
@chhwang chhwang mentioned this pull request May 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeedmaleki saeedmaleki saeedmaleki approved these changes

@chhwang chhwang chhwang approved these changes

@olsaarik olsaarik Awaiting requested review from olsaarik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Binyang2014 @chhwang @saeedmaleki