Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed wrappers for Zend APIs #1161

Merged
merged 2 commits into from
Jul 23, 2020
Merged

Removed wrappers for Zend APIs #1161

merged 2 commits into from
Jul 23, 2020

Conversation

yitam
Copy link
Contributor

@yitam yitam commented Jul 22, 2020

There is no need to use wrappers as these macros always return SUCCESS. They have been changed to return void as of php/php-src#5805

See related issue #1154 and PR for PHP 7.3 - #822

@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 75.414% when pulling f69df05 on yitam:voidify into 550a710 on microsoft:dev.

@codecov
Copy link

codecov bot commented Jul 22, 2020

Codecov Report

Merging #1161 into dev will increase coverage by 0.17%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1161      +/-   ##
==========================================
+ Coverage   78.78%   78.95%   +0.17%     
==========================================
  Files          24       24              
  Lines        7267     7207      -60     
==========================================
- Hits         5725     5690      -35     
+ Misses       1542     1517      -25     
Impacted Files Coverage Δ
.../php-7.4.8-src/ext/pdo_sqlsrv/shared/core_conn.cpp 85.47% <0.00%> (-0.32%) ⬇️
.../php-7.4.8-src/ext/pdo_sqlsrv/shared/core_stmt.cpp 80.65% <0.00%> (-0.03%) ⬇️
.../x86/php-7.4.8-src/ext/sqlsrv/shared/core_stmt.cpp 84.43% <0.00%> (-0.02%) ⬇️
.../phpdev/vc15/x86/php-7.4.8-src/ext/sqlsrv/conn.cpp 83.27% <0.00%> (ø)
.../vc15/x86/php-7.4.8-src/ext/pdo_sqlsrv/pdo_dbh.cpp 88.45% <0.00%> (ø)
...vc15/x86/php-7.4.8-src/ext/pdo_sqlsrv/pdo_init.cpp 92.72% <0.00%> (ø)
.../phpdev/vc15/x86/php-7.4.8-src/ext/sqlsrv/stmt.cpp 86.61% <0.00%> (+0.14%) ⬆️
.../x86/php-7.4.8-src/ext/sqlsrv/shared/core_conn.cpp 81.00% <0.00%> (+0.30%) ⬆️
.../php-7.4.8-src/ext/pdo_sqlsrv/shared/core_util.cpp 46.18% <0.00%> (+0.38%) ⬆️
.../x86/php-7.4.8-src/ext/sqlsrv/shared/core_util.cpp 47.03% <0.00%> (+0.39%) ⬆️
... and 3 more

@yitam yitam requested a review from v-mabarw July 22, 2020 17:42
@yitam yitam merged commit 460d9aa into microsoft:dev Jul 23, 2020
@yitam yitam deleted the voidify branch July 23, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants