Dev #787

yitam · 2018-05-30T18:20:38Z

This change is

Fixed output to test

Fix issue 705 by including the possible negative sign

Changelog changes to dev

Fixed test again

…lumns

Increase LAST_INSERT_ID_BUFF_LEN for other data types for identity columns

Reverted change handling bigint output parameters

Fix bigint output param test

Replace most strlen with strnlen_s

Modified the new issue template

Modify buildscripts to configure php.ini

Split akv verification tests to fix SSL issue

Fixed the bvt streams tests

Modified version.h for 5.2.1-preview

Added select type conversion test

Check if returned error is empty first before using count()

Changelog for 5.2.1-preview

Fixed akv test failures with win encryption

coveralls · 2018-05-30T18:35:06Z

Coverage increased (+1.4%) to 74.697% when pulling 4509756 on dev into 21ccade on master.

codecov-io · 2018-05-30T18:48:41Z

Codecov Report

Merging #787 into master will increase coverage by 1.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #787      +/-   ##
==========================================
+ Coverage   79.02%   80.06%   +1.04%     
==========================================
  Files          25       25              
  Lines        7188     7323     +135     
==========================================
+ Hits         5680     5863     +183     
+ Misses       1508     1460      -48

Impacted Files	Coverage Δ
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_conn.cpp
...rojects/php/x86/php-7.1.16-src/ext/sqlsrv/init.cpp
...x86/php-7.1.16-src/ext/sqlsrv/shared/core_init.cpp
...php-7.1.16-src/ext/pdo_sqlsrv/shared/core_init.cpp
...rojects/php/x86/php-7.1.16-src/ext/sqlsrv/stmt.cpp
...php/x86/php-7.1.16-src/ext/pdo_sqlsrv/pdo_init.cpp
...-7.1.16-src/ext/pdo_sqlsrv/shared/core_results.cpp
...rojects/php/x86/php-7.1.16-src/ext/sqlsrv/conn.cpp
...p-7.1.16-src/ext/pdo_sqlsrv/shared/core_stream.cpp
.../php/x86/php-7.1.16-src/ext/pdo_sqlsrv/pdo_dbh.cpp
... and 40 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 21ccade...4509756. Read the comment docs.

yitam and others added 30 commits April 2, 2018 15:41

Fix issue 705 by including the possible negative sign

4740ed2

Fixed output to test

54c0f5a

Added bigint into the options

88f0bcf

Merge pull request #737 from david-puglielli/pdo_utf8_conn-test-fix

a8db024

Fixed output to test

Merge pull request #732 from yitam/issue705

dd58240

Fix issue 705 by including the possible negative sign

Merge pull request #740 from Microsoft/master

72a1027

Changelog changes to dev

Fixed test again

761c03e

Fixed test again

f15a3f8

Merge pull request #741 from david-puglielli/pdo_utf8_conn-test-fix

fafb7f4

Fixed test again

Increase LAST_INSERT_ID_BUFF_LEN for other data types for identity co…

812db3d

…lumns

Merge pull request #742 from yitam/issue735

dd64980

Increase LAST_INSERT_ID_BUFF_LEN for other data types for identity columns

Reverted change handling bigint output parameters

2960738

Updated failing tests

8c681f2

Fixed binary test

99a11c1

Minor fixes

bbf951c

Merge pull request #744 from david-puglielli/Revert-bigint-change

454bc27

Reverted change handling bigint output parameters

Fix bigint output param test

2f8b9c2

Modified the driver tests as well

b8d1feb

Merge pull request #746 from yitam/BIGINTs

c87e37f

Fix bigint output param test

Replace most strlen with strnlen_s

93b9938

Merge pull request #747 from yitam/strlen

7a531d9

Replace most strlen with strnlen_s

Modified the new issue template

9c78b1e

Workaround for pip install + ODBC 17 in windows

6365fbb

Further simplified the issue template

c553105

Merge pull request #752 from yitam/template

b34d5bd

Modified the new issue template

Modify buildscripts to configure php.ini

7a3d698

Merge pull request #753 from yitam/phpini

16e0b89

Modify buildscripts to configure php.ini

Use latest build scripts for testing with php 7.2

6b6500f

Debugging some more

d54f703

Tried not to rename the extensions

a548fcb

yitam and others added 25 commits May 24, 2018 15:44

Added a couple more fixes and elaborated some comments

4c06237

Fixed some typos

8356b15

Modified version.h for 5.2.1-preview

d26440b

Split akv verification tests to fix SSL issue

cee6370

Corrected the expected output

8f5c706

Modified the comments to clarify things

6817c7b

Fixed the bvt streams tests

9e8d674

Added High Sierra and modified the macOS instructions

997e80c

Shifted NOTES

3c405f4

Refactored some akv tests, other small changes

bd9d85b

addressed review comments

1747df1

dropped tables at end

ff0e460

Merge pull request #781 from david-puglielli/akv-verification-test-fix

0861f06

Split akv verification tests to fix SSL issue

Addressed review comments

c676ae0

Merge pull request #782 from yitam/FixStreamTests

fbd686c

Fixed the bvt streams tests

Merge pull request #780 from yitam/version

45f422a

Modified version.h for 5.2.1-preview

Added select type conversion test and updated values

d35575b

Addressed review comments

c348aad

Merge pull request #783 from david-puglielli/type-conversion-for-ae

13144d9

Added select type conversion test

Check if returned error is empty first before using count()

b7a9ec6

Merge pull request #784 from yitam/fixCount

99b91f8

Check if returned error is empty first before using count()

Merge pull request #779 from yitam/changelog

9e75dfe

Changelog for 5.2.1-preview

Fixed akv test failures with win encryption

b128820

Fixed encryption check

9d1eafd

Merge pull request #785 from david-puglielli/ae-test-experiments

4509756

Fixed akv test failures with win encryption

yitam requested a review from david-puglielli May 30, 2018 18:27

david-puglielli approved these changes May 30, 2018

View reviewed changes

yitam merged commit 8f9ecde into master May 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dev #787

Dev #787

yitam commented May 30, 2018 •

edited by lilgreenbird

Loading

coveralls commented May 30, 2018

codecov-io commented May 30, 2018 •

edited

Loading

Dev #787

Dev #787

Conversation

yitam commented May 30, 2018 • edited by lilgreenbird Loading

coveralls commented May 30, 2018

codecov-io commented May 30, 2018 • edited Loading

Codecov Report

yitam commented May 30, 2018 •

edited by lilgreenbird

Loading

codecov-io commented May 30, 2018 •

edited

Loading