-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support setting flow control limits for individual stream types #3948
Support setting flow control limits for individual stream types #3948
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to add a new test case on top of MsQuic API to make sure things work as expected.
Codecov Report
@@ Coverage Diff @@
## main #3948 +/- ##
==========================================
+ Coverage 86.88% 87.25% +0.36%
==========================================
Files 56 56
Lines 16901 16958 +57
==========================================
+ Hits 14684 14796 +112
+ Misses 2217 2162 -55
|
@nibanks The PR should be ready for another round of review |
Closes #3897.
Description
This PR adds 3 new QUIC_SETTINGS members:
With the semantic that if those are set, then they overwrite the StreamRecvWindowDefault setting.
This should preserve backwards compatibility since StreamRecvWindowDefault setting still has effect, but new apps can use the new settings to specify more granular limits.
Testing
Tests in SettingsTests.cpp were updated. I will also verify the change once I managed to write a test app against it.
Documentation
Documentation files were updated.