Integrate Cross Platform Linux Packaging Tester #4466
Conversation
This reverts commit ed467f2.
Time64 fix. Azure pipeline side
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
According to the decision, we might make this part of |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4466 +/- ##
==========================================
- Coverage 86.56% 84.87% -1.69%
==========================================
Files 56 56
Lines 15521 15521
==========================================
- Hits 13435 13173 -262
- Misses 2086 2348 +262 ☔ View full report in Codecov by Sentry. |
| <TargetFramework>net9.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| <EnablePreviewFeatures>true</EnablePreviewFeatures> |
There was a problem hiding this comment.
This should not be necessary anymore.
| pushd src/cs/QuicSimpleTest && dotnet build QuicHello.net${{ matrix.vec.dotnetVersion }}.csproj -a ${{ matrix.vec.arch }} -c ${{ matrix.vec.config }} -o artifacts/net${{ matrix.vec.dotnetVersion }} -f net${{ matrix.vec.dotnetVersion }} && popd | ||
| - name: Docker Run | ||
| run: | | ||
| docker run -v $(pwd):/main ${{ matrix.vec.image }} /main/scripts/docker-script.sh ${{ matrix.vec.arch }} ${{ matrix.vec.config }} ${{ matrix.vec.tls }} ${{ matrix.vec.dotnetVersion }} |
There was a problem hiding this comment.
Does this mean that the test is run in dotnet-buildtools/prereqs image? Didn't we agree to run it in mcr.microsoft.com/dotnet/runtime? Because we also want to test if the package installs all the necessary dependencies (that might already be installed manually by dotnet-buildtools/prereqs.
There was a problem hiding this comment.
No, in some cases we're still using dotnet-buildtools/prereqs. Because we don't have other distros in our dotnet/runtime. But most of them are coming from dotnet/runtime, you can check it from matrix in the yml.
| { friendlyName: "CBL-Mariner 2.0 x64", config: "Release", os: "ubuntu-20.04", arch: "x64", tls: "openssl", image: "mcr.microsoft.com/dotnet/runtime:8.0-cbl-mariner2.0-amd64", dotnetVersion: "8.0" }, | ||
| { friendlyName: "CBL-Mariner 2.0 ARM64", config: "Release", os: "ubuntu-20.04", arch: "arm64", tls: "openssl", image: "mcr.microsoft.com/dotnet/runtime:8.0-cbl-mariner2.0-arm64v8", dotnetVersion: "8.0" }, | ||
| # Azure Linux 3.0 | ||
| { friendlyName: "AzureLinux 3.0 x64", config: "Release", os: "ubuntu-24.04", arch: "x64", tls: "openssl3", image: "mcr.microsoft.com/dotnet/sdk:9.0-preview-azurelinux3.0-amd64", dotnetVersion: "9.0", xdp: "-UseXdp" }, |
There was a problem hiding this comment.
When you said that, I also realized that on some of them we're using sdk instead of runtime I'll look at it.
/cc @ManickaP
Description
Contributes to #3460.
Fixes dotnet/runtime#101589
Goal of this PR is pulling every arch and distro combo inside github action and actually try to install libmsquic package inside of container, try to run simple tests over it.
Distro/Arch Matrix in this PR:
Testing
CI should be enough
Documentation
No
/cc @ManickaP @CarnaViire @wfurt @nibanks