Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Private Nuget Feed for OneBranch #4557

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Use Private Nuget Feed for OneBranch #4557

merged 3 commits into from
Sep 24, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Sep 24, 2024

Description

Updates internal builds to use nuget.config to use internal mirror instead of nuget.org directly.

Testing

Created internal draft PR to trigger pipeline: https://mscodehub.visualstudio.com/msquic/_build/results?buildId=531354&view=logs&j=4e010f65-6a42-5318-8120-b81b51c2abd2&t=abd3eb9e-9a6d-521e-c133-9e198ddfd123

Documentation

N/A

@nibanks nibanks added Area: Build Area: Security Related to security or quality testing labels Sep 24, 2024
@nibanks nibanks requested a review from a team as a code owner September 24, 2024 18:35
@nibanks nibanks enabled auto-merge (squash) September 24, 2024 18:35
@nibanks nibanks merged commit ee4a1bc into main Sep 24, 2024
466 checks passed
@nibanks nibanks deleted the onebranch-nuget-config branch September 24, 2024 18:59
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.50%. Comparing base (9c4dceb) to head (4c112a8).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4557      +/-   ##
==========================================
- Coverage   87.20%   86.50%   -0.71%     
==========================================
  Files          56       56              
  Lines       17354    17354              
==========================================
- Hits        15134    15012     -122     
- Misses       2220     2342     +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Build Area: Security Related to security or quality testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants