Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Access Volatile Variables Directly #4561

Merged
merged 3 commits into from
Sep 26, 2024
Merged

Don't Access Volatile Variables Directly #4561

merged 3 commits into from
Sep 26, 2024

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Sep 25, 2024

Description

We were getting arm64 build errors when we accessed volatile variables directly in C++ code. Remove those.

Testing

CI/CD

Documentation

N/A

@nibanks nibanks requested a review from a team as a code owner September 25, 2024 18:07
src/perf/lib/Tcp.cpp Outdated Show resolved Hide resolved
src/perf/lib/Tcp.cpp Outdated Show resolved Hide resolved
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (ee4a1bc) to head (694204a).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4561      +/-   ##
==========================================
- Coverage   87.61%   85.92%   -1.69%     
==========================================
  Files          56       56              
  Lines       17354    17354              
==========================================
- Hits        15204    14911     -293     
- Misses       2150     2443     +293     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nibanks nibanks enabled auto-merge (squash) September 26, 2024 12:19
@nibanks nibanks merged commit a09a6de into main Sep 26, 2024
469 of 471 checks passed
@nibanks nibanks deleted the no-volatile-access branch September 26, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants