Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert can_return_rows_from_bulk_insert to False #336

Merged
merged 5 commits into from
Jan 26, 2024
Merged

revert can_return_rows_from_bulk_insert to False #336

merged 5 commits into from
Jan 26, 2024

Conversation

mShan0
Copy link
Contributor

@mShan0 mShan0 commented Jan 18, 2024 •
edited
Loading

Changes default value of can_return_rows_from_bulk_insert in features.py back to False, sets return_rows_bulk_insert to True in settings.py for CI purposes

@mShan0 mShan0 marked this pull request as ready for review January 24, 2024 18:07
@mShan0 mShan0 merged commit ea3f0a7 into dev Jan 26, 2024
42 of 44 checks passed
@mShan0 mShan0 deleted the revert_return_rows branch January 26, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dauinsight dauinsight dauinsight approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mShan0 @dauinsight