-
Notifications
You must be signed in to change notification settings - Fork 426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated getIndexInfo() to include Columnstore indexes by using custom query. #2566
Open
Ananya2
wants to merge
3
commits into
main
Choose a base branch
from
users/anagarg/issue#2546-final
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+216
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2566 +/- ##
============================================
- Coverage 51.12% 51.11% -0.01%
+ Complexity 3940 3926 -14
============================================
Files 147 147
Lines 33456 33480 +24
Branches 5604 5606 +2
============================================
+ Hits 17105 17114 +9
+ Misses 13963 13958 -5
- Partials 2388 2408 +20 ☔ View full report in Codecov by Sentry. |
Ananya2
requested review from
lilgreenbird,
divang,
Jeffery-Wasty,
tkyc and
machavan
December 17, 2024 12:42
divang
reviewed
Dec 17, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
divang
reviewed
Dec 17, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerDatabaseMetaData.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
...est/java/com/microsoft/sqlserver/jdbc/databasemetadata/DatabaseMetadataGetIndexInfoTest.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the use of the sp_statistics stored procedure with a custom query to retrieve index information as the sp_statistics procedure did not return Columnstore indexes, so a query using sys.indexes was implemented as a workaround.
This new query ensures that all index types (Clustered, NonClustered, Columnstore) are included in the result set.
Github Issue: #2546