Skip to content

Commit

Permalink
[PolicyServicePkg] Adding MemoryAllocationLib to library classes that…
Browse files Browse the repository at this point in the history
… rely on it (#597)

## Description

PolicyServicePkg's PolicyLib rely on PolicyLibCommon, which includes
MemoryAllocationLib, header.
The Policy Libs do not enumerate MemoryAllocationLib in the
LibraryClasses section of their INF files.

If one of the enumerated library classes do not include
MemoryAllocationLib, a build error will occur.

Fixes #596 

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested
A platform threw a build error because of unresolved externals coming
from the MemoryAllocationLib usage.
Adding MemoryAllocationLib to the INFs resolved the build error. 

## Integration Instructions
N/A

---------

Signed-off-by: Aaron <105021049+apop5@users.noreply.github.com>
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
  • Loading branch information
2 people authored and kenlautner committed Jan 19, 2024
1 parent dcf8be9 commit 8c63697
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 0 deletions.
1 change: 1 addition & 0 deletions PolicyServicePkg/Library/DxePolicyLib/DxePolicyLib.inf
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@
[LibraryClasses]
BaseLib
DebugLib
MemoryAllocationLib
UefiBootServicesTableLib

[Protocols]
Expand Down
1 change: 1 addition & 0 deletions PolicyServicePkg/Library/MmPolicyLib/MmPolicyLib.inf
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@
BaseLib
DebugLib
MmServicesTableLib
MemoryAllocationLib

[Protocols]
gMmPolicyProtocolGuid ## CONSUMES
Expand Down
1 change: 1 addition & 0 deletions PolicyServicePkg/Library/PeiPolicyLib/PeiPolicyLib.inf
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
[LibraryClasses]
BaseLib
DebugLib
MemoryAllocationLib

[Ppis]
gPeiPolicyPpiGuid ## CONSUMES
Expand Down

0 comments on commit 8c63697

Please sign in to comment.