Skip to content

Commit

Permalink
Bugfix: Switch Host-Based Test DSC MSVC FLAG from \GS- to /GS- (#633)
Browse files Browse the repository at this point in the history
## Description

\GS- should be /GS-

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Tested on Q35

## Integration Instructions

N/A
  • Loading branch information
TaylorBeebe authored and kenlautner committed Dec 18, 2023
1 parent 5bb9fbe commit 97c9345
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion UnitTestFrameworkPkg/UnitTestFrameworkPkgHost.dsc.inc
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@

[BuildOptions]
# MU_CHANGE [BEGIN] - Add build flag to detect when building host-based unit tests
MSFT:*_*_*_CC_FLAGS = -D HOST_UNIT_TEST_BUILD=1 \GS- # Disable Stack Protection for Host-Based Unit Tests
MSFT:*_*_*_CC_FLAGS = -D HOST_UNIT_TEST_BUILD=1 /GS- # Disable Stack Protection for Host-Based Unit Tests
GCC:*_*_*_CC_FLAGS = -D HOST_UNIT_TEST_BUILD=1 -fno-stack-protector # Disable Stack Protection for Host-Based Unit Tests
XCODE:*_*_*_CC_FLAGS = -D HOST_UNIT_TEST_BUILD=1
# MU_CHANGE [END] - Add build flag to detect when building host-based unit tests
Expand Down

0 comments on commit 97c9345

Please sign in to comment.