Skip to content

Commit

Permalink
Support building BaseLib for AARCH64 with VC on 202311 (#662)
Browse files Browse the repository at this point in the history
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

The existing assembly file for AARCH64 has a direct reference to
InternalAssertJumpBuffer, which is an external symbol, thus causing VC
to fail compilation for this file.

The change added the explicit import to resolve the symbol.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This change is verified against QemuPkg CI build pipeline.

## Integration Instructions

N/A
  • Loading branch information
kuqin12 committed Jan 23, 2024
1 parent d4dff6b commit d51cd1b
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 0 deletions.
1 change: 1 addition & 0 deletions MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@

EXPORT SetJump
EXPORT InternalLongJump
IMPORT InternalAssertJumpBuffer ; MU_CHANGE: to resolve the symbol
; MS_CHANGE: change area name to |.text| and add an ALIGN directive
AREA |.text|, ALIGN=3, CODE, READONLY

Expand Down
1 change: 1 addition & 0 deletions MdePkg/Library/BaseLib/Arm/SetJumpLongJump.asm
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@

EXPORT SetJump
EXPORT InternalLongJump
IMPORT InternalAssertJumpBuffer ; MU_CHANGE: to resolve the symbol

AREA BaseLib, CODE, READONLY

Expand Down

0 comments on commit d51cd1b

Please sign in to comment.