Skip to content

Commit

Permalink
Bugfix: Initialize EFI_STATUS in EfiBootManagerUpdateConsoleVariable() (
Browse files Browse the repository at this point in the history
#271)

## Description

Status may not be initialized if the logic does not route through an if
statement.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

N/A

## Integration Instructions

N/A
  • Loading branch information
TaylorBeebe authored and kenlautner committed Apr 28, 2023
1 parent 92233ee commit e1f7260
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion MdeModulePkg/Library/UefiBootManagerLib/BmConsole.c
Original file line number Diff line number Diff line change
Expand Up @@ -429,7 +429,7 @@ EfiBootManagerUpdateConsoleVariable (
IN EFI_DEVICE_PATH_PROTOCOL *ExclusiveDevicePath
)
{
EFI_STATUS Status;
EFI_STATUS Status = EFI_SUCCESS; // MU_CHANGE
EFI_DEVICE_PATH_PROTOCOL *VarConsole;
EFI_DEVICE_PATH_PROTOCOL *NewDevicePath;
EFI_DEVICE_PATH_PROTOCOL *TempNewDevicePath;
Expand Down

0 comments on commit e1f7260

Please sign in to comment.