Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create the Google Test mocks for SmmBase2 Protocol. #1088

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

Eathonhsu
Copy link

@Eathonhsu Eathonhsu commented Aug 2, 2024

Description

Add mock functions under MockSmmBase2 and Create Mock for SmmBase2 protocol.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Unit tests component can call these mock functions success

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing labels Aug 2, 2024
@Eathonhsu
Copy link
Author

Hi @VivianNK, @aaronp2 and @os-d,

Kindly help to review this PR.

Sincerely,
Yi Lin Hsu

@codecov-commenter
Copy link

codecov-commenter commented Aug 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.23%. Comparing base (4790eff) to head (956b50d).

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/202311    #1088      +/-   ##
==================================================
- Coverage            1.35%    1.23%   -0.13%     
==================================================
  Files                1304     1304              
  Lines              333854   332312    -1542     
  Branches             5103     1548    -3555     
==================================================
- Hits                 4512     4091     -421     
+ Misses             329259   328080    -1179     
- Partials               83      141      +58     
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 4.90% <ø> (-0.50%) ⬇️
NetworkPkg 0.50% <ø> (-0.05%) ⬇️
PolicyServicePkg 18.40% <ø> (-12.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Eathonhsu Eathonhsu marked this pull request as draft August 2, 2024 16:41
@Eathonhsu Eathonhsu marked this pull request as ready for review August 2, 2024 16:42
Create the Google Test mocks for SmmBase2 Protocol.
@VivianNK VivianNK merged commit 2d0669d into microsoft:release/202311 Aug 2, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants