Create mocks for PlatformHookLib and PciLib #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
os-d
approved these changes
Aug 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #1094 +/- ##
==================================================
+ Coverage 1.27% 1.35% +0.08%
==================================================
Files 1302 1303 +1
Lines 332836 333838 +1002
Branches 3738 5103 +1365
==================================================
+ Hits 4229 4512 +283
- Misses 328474 329243 +769
+ Partials 133 83 -50
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Aug 7, 2024
MdeModulePkg/Test/Mock/Include/GoogleTest/Library/MockPlatformHookLib.h
Outdated
Show resolved
Hide resolved
makubacki
approved these changes
Aug 7, 2024
VivianNK
reviewed
Aug 7, 2024
VivianNK
approved these changes
Aug 8, 2024
os-d
pushed a commit
to os-d/mu_basecore
that referenced
this pull request
Aug 23, 2024
Create mocks for PlatformHookLib and PciLib - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - [ ] Includes documentation? Unit tests component can call PlatformHookLib and PciLib mock functions success N/A
os-d
pushed a commit
to os-d/mu_basecore
that referenced
this pull request
Aug 23, 2024
Create mocks for PlatformHookLib and PciLib - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - [ ] Includes documentation? Unit tests component can call PlatformHookLib and PciLib mock functions success N/A
os-d
pushed a commit
that referenced
this pull request
Aug 24, 2024
Create mocks for PlatformHookLib and PciLib - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [x] Includes tests? - [ ] Includes documentation? Unit tests component can call PlatformHookLib and PciLib mock functions success N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create mocks for PlatformHookLib and PciLib
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Unit tests component can call PlatformHookLib and PciLib mock functions success
Integration Instructions
N/A