Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CHERRY-PICK] MdePkg: Bring in mocks from 2311 #1139

Merged

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Sep 12, 2024

Description

Add mocks from 2311

Cherry picked and squashed the following commits:
a5ba951
5aa1be5

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested in 202311 CI

Integration Instructions

N/A

@VivianNK VivianNK requested review from os-d and apop5 September 12, 2024 18:17
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.59%. Comparing base (95a58f8) to head (7d25d20).

Additional details and impacted files
@@               Coverage Diff               @@
##           release/202405    #1139   +/-   ##
===============================================
  Coverage            1.59%    1.59%           
===============================================
  Files                1448     1448           
  Lines              362500   362500           
  Branches             5632     5632           
===============================================
  Hits                 5776     5776           
  Misses             356617   356617           
  Partials              107      107           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.42% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VivianNK VivianNK force-pushed the personal/vnowkakeane/2311-mock-cp branch from 4de25db to 0dc372b Compare September 12, 2024 19:51
@VivianNK VivianNK changed the title Cherry pick mocks from 2311 [CHERRY-PICK] Bring in mocks from 2311 Sep 12, 2024
@VivianNK VivianNK changed the title [CHERRY-PICK] Bring in mocks from 2311 [CHERRY-PICK] MdePkg: Bring in mocks from 2311 Sep 12, 2024
@VivianNK VivianNK force-pushed the personal/vnowkakeane/2311-mock-cp branch 2 times, most recently from 6a55fbb to 40c3d7e Compare September 12, 2024 19:55
Add gMock Functions under MockUefiBootServicesTableLib and
MockUefiRuntimeServicesTableLib.
Create Mock for DxeServicesTableLib

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com>
Co-authored-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com>
Co-authored-by: YiTa-AMI <v-yitawu@microsoft.com>
@VivianNK VivianNK force-pushed the personal/vnowkakeane/2311-mock-cp branch from 40c3d7e to 7d25d20 Compare September 12, 2024 19:57
@VivianNK VivianNK merged commit ba672c3 into microsoft:release/202405 Sep 12, 2024
31 checks passed
@VivianNK VivianNK deleted the personal/vnowkakeane/2311-mock-cp branch September 12, 2024 21:27
apop5 pushed a commit to apop5/mu_basecore that referenced this pull request Sep 20, 2024
## Description

Add mocks from 2311

Cherry picked and squashed the following commits:
a5ba951
5aa1be5

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Tested in 202311 CI

## Integration Instructions

N/A

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@microsoft.com>
Co-authored-by: v-sbolisetti <v-sbolisetti@microsoft.com>
Co-authored-by: YiTa-AMI <v-yitawu@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants