Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQUASH ON REBASE] ImageValidation.py: Support gitignore style syntax for file exclusion #1140

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

Javagedes
Copy link
Contributor

@Javagedes Javagedes commented Sep 13, 2024

Description

Add gitignore style syntax for file exclusion

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Squash into 6310e1e

How This Was Tested

Ensured existing syntax (filename only) continues to work. Ensured gitignore style syntax now works.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 13, 2024
@Javagedes Javagedes changed the title ImageValidation.py: Support gitignore style syntax for file exclusion [202405] ImageValidation.py: Support gitignore style syntax for file exclusion Sep 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.59%. Comparing base (66f3d70) to head (fe3b8f2).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1140   +/-   ##
===========================================
  Coverage        1.59%    1.59%           
===========================================
  Files            1448     1448           
  Lines          362490   362490           
  Branches         5632     5632           
===========================================
  Hits             5776     5776           
  Misses         356607   356607           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.68% <ø> (ø)
MdePkg 5.42% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into dev/202405 and be cp'd into release/202405 if it meets the criteria.

@Javagedes Javagedes changed the base branch from release/202405 to dev/202405 September 13, 2024 17:47
@Javagedes
Copy link
Contributor Author

This should go into dev/202405 and be cp'd into release/202405 if it meets the criteria.

@os-d Updated target to dev/202405- thanks!

@github-actions github-actions bot added the language:python Pull requests that update Python code label Sep 13, 2024
@github-actions github-actions bot removed the language:python Pull requests that update Python code label Sep 13, 2024
@Javagedes Javagedes changed the title [202405] ImageValidation.py: Support gitignore style syntax for file exclusion [SQUASH ON REBASE] ImageValidation.py: Support gitignore style syntax for file exclusion Sep 13, 2024
@Javagedes Javagedes enabled auto-merge (squash) September 18, 2024 23:05
@makubacki makubacki merged commit 23f8354 into microsoft:dev/202405 Sep 18, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants