MdeModulePkg/HiiDatabaseDxe: Correcting a Codeql change

[apop5]

Description

Due to a change to address CodeQl issues, the HiiDatabase could not return a default values for IFRs.

It was tracked back to the conditional check encompassing too much of the code, and preventing the loop from iterating through all the possible variable storage

• Impacts functionality?
  • Functionality - Does the change ultimately impact how firmware functions?
  • Examples: Add a new library, publish a new PPI, update an algorithm, ...
• Impacts security?
  • Security - Does the change have a direct security impact on an application,
    flow, or firmware?
  • Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
• Breaking change?
  • Breaking change - Will anyone consuming this change experience a break
    in build or boot behavior?
  • Examples: Add a new library class, move a module to a different repo, call
    a function in a new library class in a pre-existing module, ...
• Includes tests?
  • Tests - Does the change include any explicit test code?
  • Examples: Unit tests, integration tests, robot tests, ...
• Includes documentation?
  • Documentation - Does the change contain explicit documentation additions
    outside direct code modifications (and comments)?
  • Examples: Update readme file, add feature readme file, link to documentation
    on an a separate Web page, ...

How This Was Tested

Prior to this change, a platform loading defaults would not change all the settings, only the subset found in the first variable storage.

Integration Instructions

n/a

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes are missing coverage. Please review.

Project coverage is 1.22%. Comparing base (88c69a3) to head (4cfafb5).

Files	Patch %	Lines
MdeModulePkg/Universal/HiiDatabaseDxe/Database.c	0.00%	38 Missing ⚠️

Additional details and impacted files

@@               Coverage Diff               @@
##           release/202311     #860   +/-   ##
===============================================
  Coverage            1.22%    1.22%           
===============================================
  Files                1303     1303           
  Lines              335702   335702           
  Branches             3189     3189           
===============================================
  Hits                 4118     4118           
  Misses             331508   331508           
  Partials               76       76           

Flag	Coverage Δ
MdeModulePkg	0.68% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.