Added MockPciIoProtocol and MockLocalApicLib #890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
impact:non-functional
v-bhavanisu
force-pushed
the
personal/bhavani/MockPciIoProtocolLocalApicLib
branch
4 times, most recently
from
4b5ad2c
to
5aaa5e0
Compare
VivianNK
approved these changes
Jun 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #890 +/- ##
===============================================
Coverage 1.22% 1.22%
===============================================
Files 1304 1304
Lines 335782 335782
Branches 3189 3189
===============================================
Hits 4118 4118
Misses 331588 331588
Partials 76 76
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
apop5
reviewed
Jun 5, 2024
UefiCpuPkg/Test/Mock/Include/GoogleTest/Library/MockLocalApicLib.h
Outdated
Show resolved
Hide resolved
v-bhavanisu
force-pushed
the
personal/bhavani/MockPciIoProtocolLocalApicLib
branch
from
5aaa5e0
to
8f8cc11
Compare
v-bhavanisu
force-pushed
the
personal/bhavani/MockPciIoProtocolLocalApicLib
branch
from
8f8cc11
to
224a58f
Compare
apop5
approved these changes
Jun 5, 2024
ProjectMuBot
added a commit
to microsoft/mu_tiano_platforms
that referenced
this pull request
Jun 7, 2024
Introduces 14 new commits in [MU_BASECORE](https://github.com/microsoft/mu_basecore.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_basecore/commit/ff628092e879873651e113cc487239897e97526c">ff6280</a> pip: update edk2-pytool-extensions requirement from ~=0.27.4 to ~=0.27.5 (<a href="https://github.com/microsoft/mu_basecore/pull/876">#876</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/72d4761b624ddf3b0e3d98a4acc14bc8a6a41df0">72d476</a> MuCodeQlQueries.qls: Pin to the 0.9.12 codeq/cpp-queries pack (<a href="https://github.com/microsoft/mu_basecore/pull/882">#882</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/58a2bcafc7e95ffbda50838c44d3130760a9e4b4">58a2bc</a> MdePkg: Add Random Number Generator (RNG) PPI</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/fc52e410f6a343e7af90ddba4f03074c0237916e">fc52e4</a> MdePkg: Add PeiRngLib</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/abd6ffcb58f1215494125ef7a5b375e3076a2bb3">abd6ff</a> pip: update edk2-pytool-library requirement from ~=0.21.5 to ~=0.21.6 (<a href="https://github.com/microsoft/mu_basecore/pull/889">#889</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/9051d2e811e41a537904344b7f567db38a328ff9">9051d2</a> Set EFI_MEMORY_SP as System Memory (<a href="https://github.com/microsoft/mu_basecore/pull/886">#886</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/304009e91704ea9756af10bbde8b5fed72b5fb71">304009</a> Added MockPciIoProtocol and MockLocalApicLib (<a href="https://github.com/microsoft/mu_basecore/pull/890">#890</a>)</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/ff7dabfdca8534a1d1b3551e91b739be20a5f8fc">ff7dab</a> [CHERRY-PICK] UefiCpuPkg/PiSmmCpuDxeSmm: distinguish GetSmBase() failure modes</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/719bf756ea6d94ef800eaab4601d3ed52423ef35">719bf7</a> [CHERRY-PICK] UefiCpuPkg/PiSmmCpuDxeSmm: fix NULL deref when gSmmBaseHobGuid is missing</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/8451c12e5c9486d74f4ce4ae2aeb1ec4d0851ec6">8451c1</a> BaseTools: tools_def: Add support for CLANDPDB with AARCH64</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/71d4330676132bbea5844dca9932d35a705f3095">71d433</a> MdePkg: Include: Fix unsupported directives from CLANDPDB</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/e38829aecb27be7958844ccb30da2467d4a69306">e38829</a> MdePkg: CompilerIntrinsicsLib: Resolve unsupported syntax by CLANDPDB</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/c0aa7e0d5914c82d3d937e1a57b7510afb17ce2d">c0aa7e</a> [SQUASH ON REBASE] UefiCpuPkg: AsmMacroIoLib: Remove duplicate file</li> <li><a href="https://github.com/microsoft/mu_basecore/commit/4298c31df7a47fc9731885292daefe8c170dd0c7">4298c3</a> MdeModulePkg: DeviceManagerUiLib: Fix using uninitialized variable</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
os-d
pushed a commit
to os-d/mu_basecore
that referenced
this pull request
Aug 23, 2024
# Preface Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). ## Description Added MockPciIoProtocol and MockLocalApicLib to be used in GoogleTests For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Integrated these in internal repo for a GoogleTest and ensured no build errors ## Integration Instructions N/A
os-d
pushed a commit
that referenced
this pull request
Aug 24, 2024
# Preface Please ensure you have read the [contribution docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior to submitting the pull request. In particular, [pull request guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices). ## Description Added MockPciIoProtocol and MockLocalApicLib to be used in GoogleTests For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Integrated these in internal repo for a GoogleTest and ensured no build errors ## Integration Instructions N/A
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.
Description
Added MockPciIoProtocol and MockLocalApicLib to be used in GoogleTests
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Integrated these into Intel Gen 11 for a GoogleTest and ensured no build errors
Integration Instructions
N/A