Commits on Jun 6, 2024

1. UnitTestFrameworkPkg: Fix Google Test components with multiple files …

   REF: #891
     - Dropping GOOGLETEST_HOST_UNIT_BUILD option as release/202302 does
       not have any expectation to support it.
   
   REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4610
   
   Google Test hides test registration in global constructors on global
   objects. Global constructors are traditionally implemented by placing
   references to the global constructor's symbol in special sections
   (traditionally named .ctors or .init_array). These sections are not
   explicitly referenced by the linker, and libc only looks at special
   start and end symbols (and calls them).
   
   This works fine if you're linking a program manually using
   
       gcc a.o b.o c.o -o test_suite
   
   but fails miserably when using static libraries (such as what EDK2
   does), because traditional static archive symbol resolution rules don't
   allow for object files to be pulled in to the link if there isn't an
   undefined symbol reference to that .o elsewhere.
   
   Fix it by passing --whole-archive (GCC) and /WHOLEARCHIVE (MSVC). These
   options force the linker to pull in the entire static library, thus
   including previously-unreferenced constructors and making sure
   multi-file gtest EDK2 components work.
   
   Cc: Michael D Kinney <michael.d.kinney@intel.com>
   Cc: Michael Kubacki <mikuback@linux.microsoft.com>
   Cc: Sean Brogan <sean.brogan@microsoft.com>
   
   Reviewed-by: Cc: Michael D Kinney <michael.d.kinney@intel.com>
   
   This corrects an issue with MSVC where unit tests are not being linked
   correctly - thus creating unit tests with zero tests
   
   For each item, place an "x" in between `[` and `]` if true. Example:
   `[x]`.
   _(you can also check items in the GitHub UI)_
   
   - [ ] Impacts functionality?
   - [ ] Impacts security?
   - [ ] Breaking change?
   - [x] Includes tests?
     - This will cause unit tests to actually run with MSVC
   - [ ] Includes documentation?
   
   Local builds with Host Based Unit Tests
   
   N/A
   
   ---------
   
   Signed-off-by: Pedro Falcato <pedro.falcato@gmail.com>
   Co-authored-by: Pedro Falcato <pedro.falcato@gmail.com>
   Co-authored-by: Oliver Smith-Denny <osde@microsoft.com>

   

   3 people committed Jun 6, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for a2fc339
   • Browse repository at this point

   Copy the full SHA

   a2fc339 View commit details

   Browse the repository at this point in the history