BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py #899

antklein · 2024-06-10T22:51:53Z

Description

Fix invalid escape sequence in BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py. These warnings are exposed by Python 3.12.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

Impacts functionality?
- Functionality - Does the change ultimately impact how firmware functions?
- Examples: Add a new library, publish a new PPI, update an algorithm, ...
Impacts security?
- Security - Does the change have a direct security impact on an application,
  flow, or firmware?
- Examples: Crypto algorithm change, buffer overflow fix, parameter
  validation improvement, ...
Breaking change?
- Breaking change - Will anyone consuming this change experience a break
  in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo, call
  a function in a new library class in a pre-existing module, ...
Includes tests?
- Tests - Does the change include any explicit test code?
- Examples: Unit tests, integration tests, robot tests, ...
Includes documentation?
- Documentation - Does the change contain explicit documentation additions
  outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to documentation
  on an a separate Web page, ...

How This Was Tested

Validated no functional changes to HostBasedUnitTestRunner.

Integration Instructions

N/A

github-actions · 2024-06-10T22:52:07Z

⚠️ Please add a meaningful PR title (remove the 'Personal/' prefix from the title).

codecov-commenter · 2024-06-10T23:06:21Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.35%. Comparing base (1475a86) to head (d11a4bc).

Additional details and impacted files

@@                Coverage Diff                 @@
##           release/202311     #899      +/-   ##
==================================================
- Coverage            1.35%    1.35%   -0.01%     
==================================================
  Files                1304     1304              
  Lines              333790   333790              
  Branches             5103     5103              
==================================================
- Hits                 4512     4510       -2     
- Misses             329195   329197       +2     
  Partials               83       83

Flag	Coverage Δ
MdeModulePkg	`0.68% <ø> (ø)`
MdePkg	`5.39% <ø> (-0.01%)`	⬇️
NetworkPkg	`0.55% <ø> (ø)`
PolicyServicePkg	`30.41% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…asedUnitTest.py (microsoft#899) ## Description Fix invalid escape sequence in BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py. These warnings are exposed by Python 3.12. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Validated no functional changes to HostBasedUnitTestRunner. ## Integration Instructions N/A

…asedUnitTest.py (#899) ## Description Fix invalid escape sequence in BaseTools/Plugin/HostBasedUnitTestRunner/HostBasedUnitTestRunner.py. These warnings are exposed by Python 3.12. For each item, place an "x" in between `[` and `]` if true. Example: `[x]`. _(you can also check items in the GitHub UI)_ - [ ] Impacts functionality? - **Functionality** - Does the change ultimately impact how firmware functions? - Examples: Add a new library, publish a new PPI, update an algorithm, ... - [ ] Impacts security? - **Security** - Does the change have a direct security impact on an application, flow, or firmware? - Examples: Crypto algorithm change, buffer overflow fix, parameter validation improvement, ... - [ ] Breaking change? - **Breaking change** - Will anyone consuming this change experience a break in build or boot behavior? - Examples: Add a new library class, move a module to a different repo, call a function in a new library class in a pre-existing module, ... - [ ] Includes tests? - **Tests** - Does the change include any explicit test code? - Examples: Unit tests, integration tests, robot tests, ... - [ ] Includes documentation? - **Documentation** - Does the change contain explicit documentation additions outside direct code modifications (and comments)? - Examples: Update readme file, add feature readme file, link to documentation on an a separate Web page, ... ## How This Was Tested Validated no functional changes to HostBasedUnitTestRunner. ## Integration Instructions N/A

github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact labels Jun 10, 2024

antklein changed the title ~~Personal/antklein/invalid escape hostbasedunittest~~ Fix invalid escape in HostBasedUnitTest.py Jun 10, 2024

fix invalid escape sequence in HostBasedUnitTestRunner.py

d11a4bc

antklein force-pushed the personal/antklein/invalid_escape_hostbasedunittest branch from 804b14d to d11a4bc Compare June 11, 2024 16:24

Flickdm approved these changes Jun 12, 2024

View reviewed changes

apop5 approved these changes Jun 12, 2024

View reviewed changes

apop5 changed the title ~~Fix invalid escape in HostBasedUnitTest.py~~ BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py Jun 12, 2024

apop5 merged commit 23c33e2 into microsoft:release/202311 Jun 12, 2024
41 checks passed

ProjectMuBot mentioned this pull request Jun 28, 2024

Bump MU_BASECORE from 2023110008.1.0 to 2023110008.1.1 microsoft/mu_tiano_platforms#986

Closed

ProjectMuBot mentioned this pull request Jul 13, 2024

Bump MU_BASECORE from 2023110008.1.0 to 2023110009.0.0 microsoft/mu_tiano_platforms#990

Closed

ProjectMuBot mentioned this pull request Jul 14, 2024

Bump MU_BASECORE from 2023110008.1.0 to 2023110009.0.1 microsoft/mu_tiano_platforms#991

Closed

ProjectMuBot mentioned this pull request Jul 17, 2024

Bump MU_BASECORE from 2023110008.1.0 to 2023110010.0.0 and MM_SUPV from v12.0.0 to v12.0.1 microsoft/mu_tiano_platforms#993

Closed

ProjectMuBot mentioned this pull request Jul 30, 2024

Bump MU_BASECORE from 2023110008.1.0 to 2023110010.0.1 microsoft/mu_tiano_platforms#1004

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py #899

BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py #899

antklein commented Jun 10, 2024 •

edited by apop5

Loading

github-actions bot commented Jun 10, 2024

codecov-commenter commented Jun 10, 2024 •

edited

Loading

BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py #899

BaseTools/Plugin/HostBasedUnitTestRunner: Fix invalid escape in HostBasedUnitTest.py #899

Conversation

antklein commented Jun 10, 2024 • edited by apop5 Loading

Description

How This Was Tested

Integration Instructions

github-actions bot commented Jun 10, 2024

codecov-commenter commented Jun 10, 2024 • edited Loading

Codecov Report

antklein commented Jun 10, 2024 •

edited by apop5

Loading

codecov-commenter commented Jun 10, 2024 •

edited

Loading