Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Binary Suffix to .vl #100

Merged
merged 2 commits into from
Jan 31, 2023
Merged

Change Binary Suffix to .vl #100

merged 2 commits into from
Jan 31, 2023

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Jan 31, 2023

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

Standardize the binary suffix output by ConfigEditor to .vl to be in line with other tools and
dmpstore. This reflects the variable list format being used by the binary output as opposed to the generic .bin suffix.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested manually with the ConfigEditor loading different binary files.

Integration Instructions

To integrate this change, either manually change the suffix of existing binary files to .vl or make
the changes in the ConfigEditor UI tool and save new binary files.

@os-d os-d requested review from kuqin12 and apop5 January 31, 2023 23:39
@github-actions github-actions bot added language:python Pull requests that update Python code impact:breaking-change Requires integration attention labels Jan 31, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #100 (9c84dbc) into main (1c2942f) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #100   +/-   ##
=======================================
  Coverage   46.10%   46.10%           
=======================================
  Files          18       18           
  Lines        6765     6765           
=======================================
  Hits         3119     3119           
  Misses       3646     3646           
Flag Coverage Δ
Linux 46.10% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
SetupDataPkg/Tools/ConfigEditor.py 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@os-d os-d merged commit e5c8cef into microsoft:main Jan 31, 2023
@os-d os-d deleted the osde/vl branch January 31, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:breaking-change Requires integration attention language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants