Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a Python tool issue introduced during cleaning #12

Merged
merged 1 commit into from
Jul 1, 2022

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Jun 30, 2022

This issue was introduced during cleaning the Python script for linting compliance. The original code will take the key from previous round of parsing, which will trip on the linting error. This change will set it to the global variable of this class instance to avoid linting violation or functional discontinuities.

@kuqin12 kuqin12 requested a review from cfernald June 30, 2022 21:56
@kuqin12 kuqin12 merged commit 83088c3 into microsoft:main Jul 1, 2022
Brent-A pushed a commit to Brent-A/mu_feature_config that referenced this pull request Jul 8, 2022
This issue was introduced during cleaning the Python script for linting compliance. The original code will take the key from previous round of parsing, which will trip on the linting error. This change will set it to the global variable of this class instance to avoid linting violation or functional discontinuities.

Signed-off-by: Kun Qin <kun.qin@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants