Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupDataPkg: apply cpp uncrustify changes #291

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

VivianNK
Copy link
Contributor

@VivianNK VivianNK commented Dec 19, 2023

Description

Updating Mu projects to apply uncrusty formatting for Cpp files, config updated upstream in edk2 tianocore/edk2#4957 .

Config will be updated in mu_basecore microsoft/mu_basecore#609.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Local CI build

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Dec 19, 2023
@makubacki makubacki self-requested a review December 19, 2023 18:24
Copy link
Member

@makubacki makubacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with request to update PR description.

@VivianNK VivianNK merged commit 02367f1 into microsoft:main Dec 21, 2023
17 checks passed
@VivianNK VivianNK deleted the vnowkakeane/uncrustify_cpp branch December 21, 2023 20:16
VivianNK added a commit to microsoft/mu_basecore that referenced this pull request Dec 22, 2023
## Description

Cherry pick uncrustify changes for cpp from edk2 and apply them to
relevant files.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [x] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Implements new uncrustify standard that needs to be applied to all
.cpp files and some cpp-related .h files(GoogleTests). Will need to
update the following repos:
- mu feature config (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_config#291)
- mu feature ipmi (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_ipmi#197)
- mu tiano plus [Draft
PR](microsoft/mu_tiano_plus#215)

- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Local CI build

## Integration Instructions

WIll need to have up to date mu_tiano_plus branch once merged.

---------

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
kenlautner pushed a commit to microsoft/mu_basecore that referenced this pull request Jan 19, 2024
Cherry pick uncrustify changes for cpp from edk2 and apply them to
relevant files.

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [x] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Implements new uncrustify standard that needs to be applied to all
.cpp files and some cpp-related .h files(GoogleTests). Will need to
update the following repos:
- mu feature config (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_config#291)
- mu feature ipmi (not dependent on this PR - only cpp file changes)
[PR](microsoft/mu_feature_ipmi#197)
- mu tiano plus [Draft
PR](microsoft/mu_tiano_plus#215)

- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

Local CI build

WIll need to have up to date mu_tiano_plus branch once merged.

---------

Signed-off-by: Vivian Nowka-Keane <vnowkakeane@linux.microsoft.com>
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request Feb 7, 2024
Introduces 20 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/bd10bc48266353538370f92cac605d1c35b1b395">bd10bc</a> pip: bump edk2-pytool-extensions from 0.26.2 to 0.26.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/287">#287</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/aa1c06bfa33e899330eaac204dbd41234b4b3546">aa1c06</a> pip: bump edk2-pytool-library from 0.19.7 to 0.19.8 (<a href="https://github.com/microsoft/mu_feature_config/pull/288">#288</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/b220e718d0e2b8825208fec91e2d10e4f07f5267">b220e7</a> Repo File Sync: Update GitHub actions in CodeQL workflow (<a href="https://github.com/microsoft/mu_feature_config/pull/292">#292</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/8bda1c255a77520432d37f70e3f4bb49860ab098">8bda1c</a> pip: bump xmlschema from 2.5.0 to 2.5.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/293">#293</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/55beba675ee6d0bf0390703e2cda7309ce2f8154">55beba</a> pip: bump edk2-pytool-extensions from 0.26.3 to 0.26.4 (<a href="https://github.com/microsoft/mu_feature_config/pull/294">#294</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/02367f1eba365565cc284a287f7c4ac0851b2363">02367f</a> SetupDataPkg: apply cpp uncrustify changes (<a href="https://github.com/microsoft/mu_feature_config/pull/291">#291</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/8520de742235bfbe8325c5810a0e71993fc6925d">8520de</a> pip: bump regex from 2023.10.3 to 2023.12.25 (<a href="https://github.com/microsoft/mu_feature_config/pull/295">#295</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/4e72b3d1909c28c522620d79e784bfc64c2c5008">4e72b3</a> pip: bump pytest from 7.4.3 to 7.4.4 (<a href="https://github.com/microsoft/mu_feature_config/pull/296">#296</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/4c9b37b80917dd42d75ab8b043a6ec90f731febe">4c9b37</a> pip: bump xmlschema from 2.5.1 to 3.0.1 (<a href="https://github.com/microsoft/mu_feature_config/pull/297">#297</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/e34661ba6f0b970545fccb7040926498a2d4fde4">e34661</a> pip: bump flake8 from 6.1.0 to 7.0.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/298">#298</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/27a061f2b66e22bf92356919d5f0d0f4679462d3">27a061</a> .git-blame-ignore-revs: Ignore Line Ending and Uncrustify only commits (<a href="https://github.com/microsoft/mu_feature_config/pull/299">#299</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/4f71598a50e78aeaa39e2bc9b6323ca98e33ba52">4f7159</a> pip: bump edk2-pytool-library from 0.19.8 to 0.19.9 (<a href="https://github.com/microsoft/mu_feature_config/pull/300">#300</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/d120a65db1c0711c35cac3b9c8bffc47bf0f3deb">d120a6</a> GitHub Action: Bump actions/cache from 3 to 4 (<a href="https://github.com/microsoft/mu_feature_config/pull/301">#301</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/908e2014da7905888824db15f404176e203b49bf">908e20</a> Repo File Sync: Support CodeQL Plugin in BaseTools (<a href="https://github.com/microsoft/mu_feature_config/pull/302">#302</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/f62fb4eb4b2b1a1ff850d5735d5d52a4b6f5d4c6">f62fb4</a> Update pip-requirements.txt (<a href="https://github.com/microsoft/mu_feature_config/pull/307">#307</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/4cad90f1365d4e26cd463427b93025791e0a9d29">4cad90</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/303">#303</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/647df57b51ab4cfb6b008c5d0d410c6dc0145ad4">647df5</a> GitHub Action: Bump robinraju/release-downloader from 1.8 to 1.9 (<a href="https://github.com/microsoft/mu_feature_config/pull/308">#308</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/6767d41eae3cd828df884206112b67eb66d3778f">6767d4</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/310">#310</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/cc030257266777f304e61f511083903b009a326f">cc0302</a> pip: bump pytest from 7.4.4 to 8.0.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/309">#309</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c723eeb9ccb233a743b5b1c4023099fee25fe38b">c723ee</a> pip: bump pyopenssl from 23.3.0 to 24.0.0 (<a href="https://github.com/microsoft/mu_feature_config/pull/304">#304</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants