-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supply unsigned xml based on system operation mode #31
Conversation
I'm confused as to the Peim's name, ConfDfciUnsignedListInit. The Peim is setting a Pcd buffer with a specific guid. Why is the peim named Unsigned List init? |
Because this module is supposed to populate the file GUID of the xml that DFCI will look up for unsigned settings. The idea is that before the DFCI has a chance to look at the file guid PCD, this PEIM will update the PCD content based on the system operation mode. If this is MFG mode, that means the unsigned settings will be accepted, thus the file GUID PCD contains a legit value. Otherwise, it will be supplied with a bogus/null value so that DFCI will not be able to locate any xml and eventually not taking any unsigned settings. |
Tested on QEMU and verified that the system will not accept any unsigned settings when the system is in MFG mode. |
## @file | ||
# Initialize DFCI unsigned list. | ||
# | ||
# Copyright (C) Microsoft Corporation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: (c)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot, i missed this one... sorry
This change will change the DFCI unsigned setting's XML file GUID based on the current system mode. Such that on non-MFG mode, the DFCI will not accept unsigned settings. When the system is in MFG mode, the system will only block the settings listed in the XML file.