Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove edk2-basetools #315

Merged
merged 2 commits into from
Feb 13, 2024
Merged

Conversation

Javagedes
Copy link
Contributor

Description

Removes edk2-basetools from pip-requirements.txt and any usage of it in the CISettings.py. The is done as there are changes in the build tools python source code that are available locally in BaseTools (as is managed by Project Mu) that is not available in edk2-basetools.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Verified the build system continues to use the local python source

Integration Instructions

N/A - only effects this repository's CI system.

Removes edk2-basetools from pip-requirements.txt and any usage of it
in the CISettings.py. The is done as there are changes in the build
tools python source code that are available locally in BaseTools (as i
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Feb 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8415b16) 36.10% compared to head (6c9d477) 36.10%.

❗ Current head 6c9d477 differs from pull request most recent head ec3b57d. Consider uploading reports for the commit ec3b57d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   36.10%   36.10%           
=======================================
  Files          31       31           
  Lines        6226     6226           
  Branches      447      447           
=======================================
  Hits         2248     2248           
  Misses       3976     3976           
  Partials        2        2           
Flag Coverage Δ
Linux 27.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Javagedes Javagedes merged commit e0c8db0 into microsoft:main Feb 13, 2024
13 checks passed
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request Feb 22, 2024
Introduces 7 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/3aee7af0d5c4d29dfd9a20f3cba72882c7306e4c">3aee7a</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/311">#311</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/10bbb1950fbe041c02ea69c3ea049122216466ab">10bbb1</a> pip: bump edk2-pytool-extensions from 0.27.0 to 0.27.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/313">#313</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c60f58cb804d0cc408e9018602f768a7ed21dcc2">c60f58</a> pip: bump edk2-pytool-library from 0.20.0 to 0.21.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/312">#312</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/8415b164aa707faa9e123386c8620343e2a2b7c3">8415b1</a> Repo File Sync: Improve inline documentation in CodeQL workflow (<a href="https://github.com/microsoft/mu_feature_config/pull/314">#314</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/e0c8db0c5079a90efaeb6dc61ef133c09a5487f4">e0c8db</a> remove edk2-basetools (<a href="https://github.com/microsoft/mu_feature_config/pull/315">#315</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/b673c319c770f23449164c94f7899b940dbf87cf">b673c3</a> pip: bump edk2-pytool-library from 0.21.2 to 0.21.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/316">#316</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/cca9d2d80aa3f120f0573a2c498528b66bd4a653">cca9d2</a> Reset ConIn on ConfApp entrypoint (<a href="https://github.com/microsoft/mu_feature_config/pull/317">#317</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants