-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove edk2-basetools #315
Conversation
Removes edk2-basetools from pip-requirements.txt and any usage of it in the CISettings.py. The is done as there are changes in the build tools python source code that are available locally in BaseTools (as i
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
=======================================
Coverage 36.10% 36.10%
=======================================
Files 31 31
Lines 6226 6226
Branches 447 447
=======================================
Hits 2248 2248
Misses 3976 3976
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Introduces 7 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_feature_config/commit/3aee7af0d5c4d29dfd9a20f3cba72882c7306e4c">3aee7a</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_config/pull/311">#311</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/10bbb1950fbe041c02ea69c3ea049122216466ab">10bbb1</a> pip: bump edk2-pytool-extensions from 0.27.0 to 0.27.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/313">#313</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/c60f58cb804d0cc408e9018602f768a7ed21dcc2">c60f58</a> pip: bump edk2-pytool-library from 0.20.0 to 0.21.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/312">#312</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/8415b164aa707faa9e123386c8620343e2a2b7c3">8415b1</a> Repo File Sync: Improve inline documentation in CodeQL workflow (<a href="https://github.com/microsoft/mu_feature_config/pull/314">#314</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/e0c8db0c5079a90efaeb6dc61ef133c09a5487f4">e0c8db</a> remove edk2-basetools (<a href="https://github.com/microsoft/mu_feature_config/pull/315">#315</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/b673c319c770f23449164c94f7899b940dbf87cf">b673c3</a> pip: bump edk2-pytool-library from 0.21.2 to 0.21.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/316">#316</a>)</li> <li><a href="https://github.com/microsoft/mu_feature_config/commit/cca9d2d80aa3f120f0573a2c498528b66bd4a653">cca9d2</a> Reset ConIn on ConfApp entrypoint (<a href="https://github.com/microsoft/mu_feature_config/pull/317">#317</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Description
Removes edk2-basetools from pip-requirements.txt and any usage of it in the CISettings.py. The is done as there are changes in the build tools python source code that are available locally in BaseTools (as is managed by Project Mu) that is not available in edk2-basetools.
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Verified the build system continues to use the local python source
Integration Instructions
N/A - only effects this repository's CI system.