Add GUIDs to CSV output and support loading CSVs based on GUID + knob name #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
language:python
os-d
commented
Jan 18, 2023
kuqin12
approved these changes
Jan 18, 2023
Codecov Report
@@ Coverage Diff @@
## main #90 +/- ##
==========================================
- Coverage 49.57% 49.42% -0.15%
==========================================
Files 17 17
Lines 6285 6306 +21
==========================================
+ Hits 3116 3117 +1
- Misses 3169 3189 +20
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
makubacki
reviewed
Jan 19, 2023
makubacki
approved these changes
Jan 19, 2023
uefibot
added a commit
that referenced
this pull request
Jan 24, 2023
Closes #85 Adds a new selection to issues to request maintainer feedback. The default is no maintainer feedback is necessary. Opting for maintainer feedback adds the `state:needs-maintainer-feedback` label to the issue. Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com> Signed-off-by: Project Mu UEFI Bot <uefibot@microsoft.com>
ProjectMuBot
pushed a commit
that referenced
this pull request
Jan 24, 2023
apop5
approved these changes
Jan 27, 2023
JoeLopez333
approved these changes
Jan 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.
Description
Make CSV loading in ConfigEditor more robust by no longer relying on filenames to load the CSV but instead
loading via namespace GUID and knob name. This change added GUIDs to the CSV output and no longer accepts the older
style CSV output that does not include the GUID information.
For each item, place an "x" in between
[and]if true. Example:[x].(you can also check items in the GitHub UI)
How This Was Tested
Manually tested with multiple CSVs and XMLs loaded in ConfigEditor, including with additional knob namespaces.
Integration Instructions
To integrate this change, either manually add the GUID
information to existing CSV files or load the XML(s) with the new version of ConfigEditor, make the CSV changes in
the tool and regenerate the CSVs.