Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvements to Windbgx integration and UEFI extension #22

Merged
merged 13 commits into from
Apr 25, 2024
Merged

Improvements to Windbgx integration and UEFI extension #22

merged 13 commits into from
Apr 25, 2024

Conversation

cfernald
Copy link
Contributor

@cfernald cfernald commented Apr 25, 2024 •
edited
Loading

Description

Improvements to the core for:

  1. Add windbg workaround PCD to allow disabling for native GDB systems.
  2. Add break reason for debugger initiated breakpoints
  3. Add workaround for [Bug]: Step does not work on initial breakpoint of module load breakpoint in windbg #10
  4. Fix .reboot not working

Improvements to UEFI Extension:

  1. Cleaned up help function
  2. Added crude implementation for adv logger parser
  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Local tests on QEMU

Integration Instructions

N/A

@cfernald cfernald requested review from os-d and kuqin12 April 25, 2024 16:59
@github-actions github-actions bot added the type:documentation Improvements or additions to documentation label Apr 25, 2024
os-d
os-d approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: typo in your PR title

@cfernald cfernald changed the title Iprovements to Windbgx integration and UEFI extension Improvements to Windbgx integration and UEFI extension Apr 25, 2024
@cfernald cfernald merged commit 8b30829 into microsoft:main Apr 25, 2024
13 checks passed
ProjectMuBot referenced this pull request in microsoft/mu_tiano_platforms May 1, 2024
@ProjectMuBot
Bumps Features/DEBUGGER from 0.1.1 to 0.1.2
795298f 
Introduces 2 new commits in [Features/DEBUGGER](https://github.com/microsoft/mu_feature_debugger.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_debugger/commit/8b30829454f953b815a4485a7e6baa7133ac9504">8b3082</a> Improvements to Windbgx integration and UEFI extension (<a href="https://github.com/microsoft/mu_feature_debugger/pull/22">#22</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_debugger/commit/cee0d1a8ffebbfa61290964c1de6e462e6d4b780">cee0d1</a> Improvements to UEFIExt and fix register writes (<a href="https://github.com/microsoft/mu_feature_debugger/pull/23">#23</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
@ProjectMuBot ProjectMuBot mentioned this pull request May 1, 2024
Merged
apop5 referenced this pull request in microsoft/mu_tiano_platforms May 1, 2024
@ProjectMuBot
Bump Features/DEBUGGER from 0.1.1 to 0.1.2 (#932)
d5f5f65 
Bumps Features/DEBUGGER from `0.1.1` to `0.1.2`


Introduces 2 new commits in
[Features/DEBUGGER](https://github.com/microsoft/mu_feature_debugger.git).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_feature_debugger/commit/8b30829454f953b815a4485a7e6baa7133ac9504">8b3082</a>
Improvements to Windbgx integration and UEFI extension (<a
href="https://github.com/microsoft/mu_feature_debugger/pull/22">#22</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_debugger/commit/cee0d1a8ffebbfa61290964c1de6e462e6d4b780">cee0d1</a>
Improvements to UEFIExt and fix register writes (<a
href="https://github.com/microsoft/mu_feature_debugger/pull/23">#23</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kuqin12 kuqin12 kuqin12 approved these changes

@os-d os-d os-d approved these changes

Assignees
No one assigned
Labels
type:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cfernald @os-d @kuqin12