Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement hardware watchpoints or data breakpoints #37

Merged
merged 5 commits into from
Jun 11, 2024

Conversation

cfernald
Copy link
Contributor

@cfernald cfernald commented Jun 11, 2024

Description

Implement up to 4 watchpoints, or data breakpoints, which are represented by the GDB breakpoints types 2-4. These can be set in windbg by using the ba command, e.g. ba w8 0x10000001. These can be set in GDB by using the watch for writes, rwatch for reads, or awatch for either.

#33

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested on Q35 and SBSA on QEMU.

Integration Instructions

N/A

@cfernald cfernald linked an issue Jun 11, 2024 that may be closed by this pull request
Copy link
Contributor

@os-d os-d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update README to include this?

@cfernald
Copy link
Contributor Author

Update README to include this?

We don't really document use of specific debugger features, but Its a good point we should have high level supported functionality somewhere. I will add this.

@cfernald cfernald enabled auto-merge (squash) June 11, 2024 17:56
@cfernald cfernald merged commit 62f9727 into microsoft:main Jun 11, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Implement data breakpoints
3 participants