Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize the FRB2 watchdog timer in DXE phase if PEI is not supported. #257

Merged
merged 4 commits into from
Sep 20, 2024

Conversation

ScottieKuo
Copy link
Contributor

Initialize the FRB2 watchdog timer in DXE phase if PEI is not supported.

Description

PEIM driver support was limited on ARM based project and caused FRB2
watchdog timer was not enabled.

Expected Behavior:
FRB2 watchdog timer should be set correctly based on policy.

FIX APPLIED:
Add FRB2 timer running check, if timer is not running and policy is set,
enable FRB2 watchdog timer.

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

Tested with ARM based project and observed the watchdog timer was set
based on policy setting.

Integration Instructions

N/A

Initialize the FRB2 watchdog timer in DXE phase if PEI is not supported.
@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Sep 18, 2024
@ScottieKuo
Copy link
Contributor Author

@ScottieKuo please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.20%. Comparing base (cbd7225) to head (71dcfd2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #257      +/-   ##
==========================================
- Coverage   28.32%   28.20%   -0.13%     
==========================================
  Files          44       44              
  Lines        2990     3003      +13     
  Branches      404      404              
==========================================
  Hits          847      847              
- Misses       2131     2144      +13     
  Partials       12       12              
Flag Coverage Δ
IpmiFeaturePkg 28.20% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@apop5 apop5 enabled auto-merge (squash) September 20, 2024 01:49
@apop5 apop5 merged commit 9768b85 into microsoft:main Sep 20, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants