Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ipmi Sensor commands Set Threshold and Get Threshold. #85

Merged
merged 8 commits into from
Mar 2, 2023

Conversation

apop5
Copy link
Contributor

@apop5 apop5 commented Feb 28, 2023

Description

Added file IpmiCommandLibNetSensor.c to hold sensor related functions.
Added functions IpmiSetSensorThreshold and IpmiGetSensorThreshold.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

n/a

Integration Instructions

N/A

@apop5 apop5 added type:enhancement New feature or pull request complexity:easy Requires minimal background information and effort to accomplish labels Feb 28, 2023
@apop5 apop5 self-assigned this Feb 28, 2023
@github-actions
Copy link

⚠️ Please add a meaningful PR title (remove the 'Personal/' prefix from the title).

@apop5 apop5 changed the title Personal/apop5/addsensorcommands Add Ipmi Sensor commands Set Threshold and Get Threshold. Feb 28, 2023
@apop5
Copy link
Contributor Author

apop5 commented Feb 28, 2023

PR is dependent on microsoft/mu_basecore#288 completing.

@apop5 apop5 merged commit 9a576ba into microsoft:main Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
complexity:easy Requires minimal background information and effort to accomplish type:enhancement New feature or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants