-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ipmi Sensor commands Set Threshold and Get Threshold. #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apop5
added
type:enhancement
New feature or pull request
complexity:easy
Requires minimal background information and effort to accomplish
labels
Feb 28, 2023
|
apop5
changed the title
Personal/apop5/addsensorcommands
Add Ipmi Sensor commands Set Threshold and Get Threshold.
Feb 28, 2023
PR is dependent on microsoft/mu_basecore#288 completing. |
cfernald
reviewed
Feb 28, 2023
IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnSensor.c
Outdated
Show resolved
Hide resolved
cfernald
approved these changes
Feb 28, 2023
makubacki
reviewed
Mar 1, 2023
makubacki
reviewed
Mar 1, 2023
IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnSensor.c
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Mar 1, 2023
IpmiFeaturePkg/Library/IpmiCommandLib/IpmiCommandLibNetFnSensor.c
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Mar 1, 2023
makubacki
approved these changes
Mar 1, 2023
Co-authored-by: Michael Kubacki <michael.kubacki@microsoft.com>
…/apop5/mu_feature_ipmi into personal/apop5/addsensorcommands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
complexity:easy
Requires minimal background information and effort to accomplish
type:enhancement
New feature or pull request
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added file IpmiCommandLibNetSensor.c to hold sensor related functions.
Added functions IpmiSetSensorThreshold and IpmiGetSensorThreshold.
For each item, place an "x" in between
[
and]
if true. Example:[x]
.(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
n/a
Integration Instructions
N/A