Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SmmCpuSyncLib to the mm supervisor core #257

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

kenlautner
Copy link
Contributor

@kenlautner kenlautner commented Mar 23, 2024

Description

Integrated the following commits from MU_BASECORE into the supervisor core (which themselves were taken from edk2):
microsoft/mu_basecore@fba09d0
microsoft/mu_basecore@f5417b8
microsoft/mu_basecore@d421e2b
microsoft/mu_basecore@bb71205

Additionally updated the override of UefiCpuPkg in the supervisor cores inf.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Tested on physical platforms with the latest MU 202311 branches. No issues observed.

Integration Instructions

N/A

@github-actions github-actions bot added the impact:non-functional Does not have a functional impact label Mar 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.47%. Comparing base (f39d1df) to head (f4d2beb).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #257   +/-   ##
=====================================
  Coverage   0.47%   0.47%           
=====================================
  Files        143     143           
  Lines      22110   22110           
  Branches      60      60           
=====================================
  Hits         105     105           
  Misses     22000   22000           
  Partials       5       5           
Flag Coverage Δ
MmSupervisorPkg 0.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@makubacki makubacki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume you confirmed the mu_basecore changes did not apply here?

@kenlautner kenlautner changed the title Updated override hash in the supervisor core Add SmmCpuSyncLib to the standalonemm core Mar 23, 2024
@kenlautner kenlautner changed the title Add SmmCpuSyncLib to the standalonemm core Add SmmCpuSyncLib to the mm supervisor core Mar 23, 2024
@kenlautner kenlautner force-pushed the update_ueficpupkg_overridehash branch from 3bd0403 to 92e2d05 Compare March 25, 2024 22:53
@kenlautner kenlautner force-pushed the update_ueficpupkg_overridehash branch from 92e2d05 to eb29274 Compare March 25, 2024 23:37
@kenlautner kenlautner enabled auto-merge (rebase) March 25, 2024 23:49
@kenlautner kenlautner merged commit 1bd76ee into microsoft:main Mar 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants