Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various fixes caught by CLANG #303

Merged
merged 3 commits into from
Jun 6, 2024
Merged

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Jun 6, 2024

Preface

Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.

Description

This change will cover a few more CLANG fixes, including uninitialized variables and unintentionally pulled in compiler intrinsics.

For each item, place an "x" in between [ and ] if true. Example: [x].
(you can also check items in the GitHub UI)

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

This was tested on QEMU Q35.

Integration Instructions

N/A

@kuqin12 kuqin12 requested a review from kenlautner June 6, 2024 05:29
@kuqin12 kuqin12 enabled auto-merge (squash) June 6, 2024 20:02
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 0.31%. Comparing base (548aad1) to head (0307d7b).

Files Patch % Lines
MmSupervisorPkg/Core/Request/UnblockMemory.c 0.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #303      +/-   ##
========================================
- Coverage   0.47%   0.31%   -0.17%     
========================================
  Files        144     144              
  Lines      22079   22061      -18     
  Branches      60      60              
========================================
- Hits         105      69      -36     
+ Misses     21969   21965       -4     
- Partials       5      27      +22     
Flag Coverage Δ
MmSupervisorPkg 0.31% <0.00%> (-0.17%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuqin12 kuqin12 merged commit 83b2f31 into microsoft:main Jun 6, 2024
8 checks passed
@kuqin12 kuqin12 deleted the fix_clang_2 branch June 6, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants