Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix override from CodeQL and cherry-picks from latest basecore #331

Merged
merged 7 commits into from
Aug 28, 2024

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Aug 28, 2024

Description

This change updated the override validation tags. It also integrates the cherry-pick commit from microsoft/mu_basecore@4d722ac.

For details on how to complete to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?

How This Was Tested

This was tested on pipeline and passed override check. Also booted on Q35 branch.

Integration Instructions

The change needs to pair with basecore commit microsoft/mu_basecore@4d722ac or later.

@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 19 lines in your changes missing coverage. Please review.

Project coverage is 0.50%. Comparing base (1900b9e) to head (ee68042).

Files with missing lines Patch % Lines
...mSupervisorPkg/Core/Services/MpService/SyncTimer.c 0.00% 8 Missing ⚠️
MmSupervisorPkg/Library/BaseLibSysCall/String.c 0.00% 6 Missing ⚠️
...mSupervisorPkg/Core/Services/MpService/MpService.c 0.00% 5 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #331      +/-   ##
========================================
- Coverage   0.50%   0.50%   -0.01%     
========================================
  Files        143     143              
  Lines      20921   20942      +21     
  Branches      60      60              
========================================
  Hits         105     105              
- Misses     20811   20832      +21     
  Partials       5       5              
Flag Coverage Δ
MmSupervisorPkg 0.50% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kuqin12 kuqin12 merged commit f12a1d5 into microsoft:main Aug 28, 2024
8 checks passed
@kuqin12 kuqin12 deleted the fix_override branch August 28, 2024 20:02
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request Aug 29, 2024
Introduces 3 new commits in [Features/MM_SUPV](https://github.com/microsoft/mu_feature_mm_supv.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_mm_supv/commit/8e4ebb00277b9757f9f9cff0d49d26c061af180e">8e4ebb</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_feature_mm_supv/pull/323">#323</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_mm_supv/commit/1900b9ea03e976105de39aa85247e7d638e6e967">1900b9</a> pip: update edk2-pytool-extensions requirement from ~=0.27.10 to ~=0.27.11 (<a href="https://github.com/microsoft/mu_feature_mm_supv/pull/324">#324</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_mm_supv/commit/f12a1d5cb674bd6ee66ac8fa14a3513f758ee425">f12a1d</a> Fix override from CodeQL and cherry-picks from latest basecore (<a href="https://github.com/microsoft/mu_feature_mm_supv/pull/331">#331</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants