Skip to content

Commit

Permalink
Fix GCC Build of AdvLoggerOsConnectorPRM (#494)
Browse files Browse the repository at this point in the history
## Description

The GCC build options in the INF referenced a function in the sample PRM
driver (and was apparently not caught by CI). Building on GCC breaks
without this function defined. Instead require that the PRM handler is
defined (so that GCC does not strip it out when building the binary,
seeing it not being referenced).

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Building on GCC.

## Integration Instructions

N/A.
  • Loading branch information
os-d authored Jun 5, 2024
1 parent 33b0a05 commit 01651e4
Showing 1 changed file with 1 addition and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -39,4 +39,4 @@
MSFT:*_*_*_GENFW_FLAGS = --keepoptionalheader

GCC:*_*_AARCH64_GENFW_FLAGS = --keepoptionalheader --prm
GCC:*_*_AARCH64_DLINK_FLAGS = -Wl,--no-gc-sections -Wl,--require-defined=PrmModuleExportDescriptor -Wl,--require-defined=CheckStaticDataBufferPrmHandler
GCC:*_*_AARCH64_DLINK_FLAGS = -Wl,--no-gc-sections -Wl,--require-defined=PrmModuleExportDescriptor -Wl,--require-defined=AdvLoggerOsConnectorPrmHandler

0 comments on commit 01651e4

Please sign in to comment.