-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing bsr64 for MathLib #492
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
os-d
approved these changes
Jun 4, 2024
apop5
approved these changes
Jun 4, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/202311 #492 +/- ##
===============================================
Coverage 10.86% 10.86%
===============================================
Files 142 142
Lines 22379 22379
Branches 1808 1808
===============================================
Hits 2431 2431
Misses 19916 19916
Partials 32 32
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ProjectMuBot
referenced
this pull request
in microsoft/mu_tiano_platforms
Jun 6, 2024
Introduces 8 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/0b2315b5f35930943382bf9aeb3712bc60753fa6">0b2315</a> pip: bump regex from 2024.5.10 to 2024.5.15 (<a href="https://github.com/microsoft/mu_plus/pull/489">#489</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/ab1129bd24b051e2f9068bb2fe7e71bb300c5283">ab1129</a> Update MorLockTestApp to fix errors with new standard return values (<a href="https://github.com/microsoft/mu_plus/pull/488">#488</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/8213f0ef0d88f9129bf82323debae78774f8da47">8213f0</a> Repo File Sync: synced file(s) with microsoft/mu_devops (<a href="https://github.com/microsoft/mu_plus/pull/490">#490</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/3709a53fb5670158f2a40b3f477730d6c0993f2c">3709a5</a> pip: bump edk2-pytool-extensions from 0.27.4 to 0.27.5 (<a href="https://github.com/microsoft/mu_plus/pull/491">#491</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/8da8aa73144066cfaf5fd404161560e63eb8bbd3">8da8aa</a> Fixing bsr64 for MathLib (<a href="https://github.com/microsoft/mu_plus/pull/492">#492</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/33b0a0580a3b6f9221cf0620b924617c93fe4d7a">33b0a0</a> pip: bump edk2-pytool-library from 0.21.5 to 0.21.6 (<a href="https://github.com/microsoft/mu_plus/pull/493">#493</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/01651e452dcac06182a43df99e66f48402063875">01651e</a> Fix GCC Build of AdvLoggerOsConnectorPRM (<a href="https://github.com/microsoft/mu_plus/pull/494">#494</a>)</li> <li><a href="https://github.com/microsoft/mu_plus/commit/0a1ce577e8c8f151f33d239ff52a80d4bc652e44">0a1ce5</a> Fixing uninitialized variable used in AdvLoggerOsConnectorPrmConfigLib (<a href="https://github.com/microsoft/mu_plus/pull/495">#495</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <mubot@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preface
Please ensure you have read the contribution docs prior
to submitting the pull request. In particular,
pull request guidelines.
Description
When using GCC(-like) compilers to build MathLib, the
sqrt_d
function will use built-in functions for bit scan reverse. However, the calculation for 64 bit BSR is incorrectly using the built-in function specifically for unsigned long, which is 32-bit for CLANGPDB and cause the unit test to fail.This change fixed the built-in function usage.
For each item, place an "x" in between
[
and]
if true. Example:[x]
.(you can also check items in the GitHub UI)
flow, or firmware?
validation improvement, ...
in build or boot behavior?
a function in a new library class in a pre-existing module, ...
outside direct code modifications (and comments)?
on an a separate Web page, ...
How This Was Tested
Unit test passed on QEMU SBSA platform built with CLANGPDB.
Integration Instructions
N/A