Skip to content

Commit

Permalink
[CodeQL] DynamicTablesPkg: TableHelperLib: Fixing a mismatched variab…
Browse files Browse the repository at this point in the history
…le size (#135)

# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

This change fixes a CodeQL issue in TableHelperLib.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [ ] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [x] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This change was tested on ARM FVP platform.

## Integration Instructions

N/A
  • Loading branch information
kuqin12 authored and kenlautner committed Oct 25, 2023
1 parent 7380908 commit 67a1b4d
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -836,7 +836,8 @@ PrintCmObjDesc (
IN UINT32 IndentLevel
)
{
UINT32 Index;
// UINT32 Index; // MU_CHANGE: Fixing CodeQL issue
UINTN Index;
UINT32 IndentIndex;
INTN SubStructSize;

Expand Down

0 comments on commit 67a1b4d

Please sign in to comment.