Skip to content

Commit

Permalink
Implement Memory Attribute Protocol Installation Policy Option (#200)
Browse files Browse the repository at this point in the history
## Description

Linux shim currently incorrectly uses the UEFI memory attribute protocol
causing a fault. The broken shim does not have the NXCOMPAT
flag, so compatibility mode can be used to uninstall the protocol
when it is loaded. For flexibility, this patch implements the policy
configuration option to allow ARM platforms to choose not to install the
protocol.

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

Tested on SBSA by running the DxePagingAuditTestApp with the protocol
policy set to TRUE and FALSE

## Integration Instructions

N/A
  • Loading branch information
TaylorBeebe authored and os-d committed Jul 22, 2024
1 parent f0ce81f commit 702ec3d
Showing 1 changed file with 18 additions and 2 deletions.
20 changes: 18 additions & 2 deletions ArmPkg/Drivers/CpuDxe/CpuDxe.c
Original file line number Diff line number Diff line change
Expand Up @@ -331,14 +331,30 @@ CpuDxeInitialize (
RemapUnusedMemoryNx ();
}

// MU_CHANGE [START]: Only install Memory Attribute Protocol if policy is enabled
Status = gBS->InstallMultipleProtocolInterfaces (
&mCpuHandle,
&gEfiCpuArchProtocolGuid,
&mCpu,
&gEfiMemoryAttributeProtocolGuid,
&mMemoryAttribute,
// &gEfiMemoryAttributeProtocolGuid,
// &mMemoryAttribute,
NULL
);
ASSERT_EFI_ERROR (Status);

if (gDxeMps.InstallMemoryAttributeProtocol) {
Status = gBS->InstallMultipleProtocolInterfaces (
&mCpuHandle,
&gEfiMemoryAttributeProtocolGuid,
&mMemoryAttribute,
NULL
);
if (EFI_ERROR (Status)) {
DEBUG ((DEBUG_ERROR, "Failed to install Memory Attribute Protocol!\n"));
}
}

// MU_CHANGE [END]

//
// Make sure GCD and MMU settings match. This API calls gDS->SetMemorySpaceAttributes ()
Expand Down

0 comments on commit 702ec3d

Please sign in to comment.