Skip to content

Commit

Permalink
RedfishPkg/RedfishDiscoverDxe: introduce PcdRedfishSendReceiveTimeout
Browse files Browse the repository at this point in the history
Introduce PCD PcdRedfishSendReceiveTimeout to RedfishDiscoverDxe
driver. The SendReceiveTimeout is hard-code value in Redfish discover
driver. With this PCD, platform owner can configure timeout value
easily.

Signed-off-by: Nickle Wang <nicklew@nvidia.com>
Cc: Abner Chang <abner.chang@amd.com>
Cc: Igor Kulchytskyy <igork@ami.com>
Reviewed-by: Abner Chang <abner.chang@amd.com>
Reviewed-by: Igor Kulchytskyy <igork@ami.com>
  • Loading branch information
nicklela authored and mergify[bot] committed Oct 18, 2023
1 parent 01e1bc2 commit 747a08e
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
Original file line number Diff line number Diff line change
Expand Up @@ -877,7 +877,7 @@ AddAndSignalNewRedfishService (
goto EXIT_FREE_CONFIG_DATA;
}

RestExHttpConfigData->SendReceiveTimeout = 5000;
RestExHttpConfigData->SendReceiveTimeout = PcdGet32 (PcdRedfishSendReceiveTimeout);
RestExHttpConfigData->HttpConfigData.HttpVersion = HttpVersion11;
RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6 = CheckIsIpVersion6 (NetworkInterface);
if (RestExHttpConfigData->HttpConfigData.LocalAddressIsIPv6) {
Expand Down
2 changes: 1 addition & 1 deletion RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.inf
Original file line number Diff line number Diff line change
Expand Up @@ -54,4 +54,4 @@

[Pcd]
gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDiscoverAccessModeInBand ## CONSUMES

gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout ## CONSUEMS
5 changes: 5 additions & 0 deletions RedfishPkg/RedfishPkg.dec
Original file line number Diff line number Diff line change
Expand Up @@ -142,3 +142,8 @@
# This PCD indicates that if BMC bootstrap credential service will be disabled by BIOS or not.
#
gEfiRedfishPkgTokenSpaceGuid.PcdRedfishDisableBootstrapCredentialService|FALSE|BOOLEAN|0x00001007
#
# The EFI_REST_EX_HTTP_CONFIG_DATA.SendReceiveTimeout value that RedfishDiscoverDxe driver
# set to EFI_REST_EX_PROTOCOL.
#
gEfiRedfishPkgTokenSpaceGuid.PcdRedfishSendReceiveTimeout|5000|UINT32|0x00001008

0 comments on commit 747a08e

Please sign in to comment.