Skip to content

Commit

Permalink
Remove MDEPKG_NDEBUG from DynamicTables.dsc.inc (#163)
Browse files Browse the repository at this point in the history
## Description

The current build option inserted from `DynamicTables.dsc.inc` making
the release build debug prints to be completely muted. This is
undesirable when platforms would like to keep logging capabilities, i.e.
advanced logger.

This change removes the build option that inserted the macro definition
and leave the option to platform consumers.

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This was tested on proprietary platforms that includes this file and
confirmed release builds can print strings to serial port.

## Integration Instructions

N/A
  • Loading branch information
kuqin12 authored and kenlautner committed Oct 25, 2023
1 parent 450558c commit 77f5406
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion DynamicTablesPkg/DynamicTables.dsc.inc
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@
[Defines]

[BuildOptions]
RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG
# MU_CHANGE: should not enforce all consumers to disable debug prints in release builds
# RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG

[LibraryClasses.common]
AcpiHelperLib|DynamicTablesPkg/Library/Common/AcpiHelperLib/AcpiHelperLib.inf
Expand Down

0 comments on commit 77f5406

Please sign in to comment.