Skip to content

Commit

Permalink
ArmGicLib/ArmGicV3: Update ICC_SG1R register (#38)
Browse files Browse the repository at this point in the history
## Description

The current register `ICC_SGI1R` builds on `ARM` but fails on `AARCH64`:

```
ArmPkg\Drivers\ArmGic\ArmGicLib\OUTPUT\GicV3\AArch64\ArmGicV3.iii(86):
  illegal flag(s) ICC_SGI1R
```

AARCH64 resgister `ICC_SG1R_EL1` performs the same function and compiles
on both architectures.


https://developer.arm.com/documentation/ddi0601/2021-03/AArch64-Registers/ICC-SGI1R-EL1--Interrupt-Controller-Software-Generated-Interrupt-Group-1-Register?lang=en
- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?

## How This Was Tested

Verified `ARM` and `AARCH64` builds.

## Integration Instructions

N/A

Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
  • Loading branch information
makubacki authored and kenlautner committed May 13, 2023
1 parent 0cb91a4 commit a300ffa
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion ArmPkg/Drivers/ArmGic/GicV3/AArch64/ArmGicV3.masm
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ ArmGicV3SetControlSystemRegisterEnable ENDP
// );
ArmGicV3SendNsG1Sgi PROC
dsb ishst
msr ICC_SGI1R, x0
msr ICC_SGI1R_EL1, x0
isb
ret
ArmGicV3SendNsG1Sgi ENDP
Expand Down

0 comments on commit a300ffa

Please sign in to comment.