Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: SBSA GUI is disabled #610

Closed
1 task done
kuqin12 opened this issue Jun 28, 2023 · 0 comments · Fixed by #611
Closed
1 task done

[Bug]: SBSA GUI is disabled #610

kuqin12 opened this issue Jun 28, 2023 · 0 comments · Fixed by #611
Assignees
@kuqin12
Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@kuqin12
Copy link
Contributor

kuqin12 commented Jun 28, 2023

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

Current top of mu_tiano_platforms has QemuSbsaPkg not able to launch GUI. The reason is that the update ConfigKnobs will directly publish the finalized policy but still has the policy DEPEX enabled.

Expected Behavior

The GUI should be enabled by default, and turned off through configuration manager.

Steps To Reproduce

  1. Build SBSA platform firmware
  2. Boot built firmware
  3. No GUI observed, even if the QEMU windows is up.

Build Environment

- OS(s): Ubuntu 22.04 on WSL v2.
- Tool Chain(s): GCC5
- Targets Impacted: DEBUG

Version Information

Likely caused by this: https://github.com/microsoft/mu_tiano_platforms/commit/b8ba64852ac40f3f882dea1e5b2bab716e0dd305.

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response
@kuqin12 kuqin12 added type:bug Something isn't working state:needs-triage Needs to triaged to determine next steps labels Jun 28, 2023
@kuqin12 kuqin12 self-assigned this Jun 28, 2023
@github-actions github-actions bot added the urgency:medium Important with a moderate impact label Jun 28, 2023
@kuqin12 kuqin12 mentioned this issue Jun 28, 2023
Merged
5 tasks
kuqin12 added a commit that referenced this issue Jun 28, 2023
@kuqin12
Removed extra indirection of policy creation from a separate model (#611
cfcc030 
)

# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

This change removed the individual policy initializers from platform
level since they are centralized to `ConfigKnobs`.

This change also removed the Depex in `ConfigKnobs` driver to fix the
dependency change.

Fixes #610.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This change was tested on QemuSbsa and booted to Windows. The QemuQ35 is
also tested and booted to shell.

## Integration Instructions

N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kuqin12 kuqin12

Labels
state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed extra indirection of policy creation from a separate model kuqin12/mu_tiano_platforms
1 participant
@kuqin12