Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DxePagingAuditTestApp Exemption From Q35 and SBSA #1001

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

os-d
Copy link
Contributor

@os-d os-d commented Jul 23, 2024

Description

The DxePagingAuditTestApp was failing on all architectures because of a misimplementation. That was fixed in
microsoft/mu_plus#528. This patch pulls in the newer mu_plus to get that change and drops the exemption from Q35 and SBSA.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

Ran paging audit test and it succeeds.

Integration Instructions

N/A.

@os-d os-d requested review from makubacki and apop5 July 23, 2024 21:41
@github-actions github-actions bot added language:python Pull requests that update Python code impact:non-functional Does not have a functional impact impact:testing Affects testing labels Jul 23, 2024
The DxePagingAuditTestApp was failing on all architectures because
of a misimplementation. That was fixed in
microsoft/mu_plus#528. This patch pulls
in the newer mu_plus to get that change and drops the exemption
from Q35 and SBSA.
@os-d os-d enabled auto-merge (squash) July 23, 2024 22:09
@os-d os-d merged commit 4a9e061 into microsoft:main Jul 23, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing language:python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants